severity 859388 important thanks On Thu, 12 Apr 2018, Julian Andres Klode wrote:
> In Ubuntu, the attached patch was applied to achieve the following: > > * scripts/blkdeactivate.sh.in: Refer to /usr/bin/sort, not /bin/sort Hi. I think we should use just "sort" instead of still hardcoding the path, as in the patch below. Hardcoding a path defeats the purpose of having a PATH and a search algorithm for commands. (I would be surprised if this is not already Debian Policy) While we are at it, I believe this is the kind of bug that we should also try to fix in stable as well, so I'm raising it to "important". Note: Not everybody will notice this because of the usr-merge thing, but I can reproduce this on brand new GCE buster instances because official GCE images do not use usr-merge at this moment. Thanks. --- a/scripts/blkdeactivate.sh.in +++ b/scripts/blkdeactivate.sh.in @@ -58,7 +58,7 @@ MPATHD_OPTS="" LSBLK="/bin/lsblk -r --noheadings -o TYPE,KNAME,NAME,MOUNTPOINT" LSBLK_VARS="local devtype local kname local name local mnt" LSBLK_READ="read -r devtype kname name mnt" -SORT_MNT="/bin/sort -r -u -k 4" +SORT_MNT="sort -r -u -k 4" # Do not show tool errors by default (only done/skipping summary # message provided by this script) and no verbose mode by default.
