Control: reopen -1
Hello,
I see that what got uploaded is
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE="$(LDFLAGS)" \
- -DBUILD_SHARED_LIBS=ON -DBUILD_DOCS=ON
+ -DBUILD_SHARED_LIBS=ON -DBUILD_DOCS=ON \
+ -DBUILD_TESTS=OFF
-- $(CMAKE_FLAGS) \
- -DBUILD_SHARED_LIBS=OFF -DBUILD_DOCS=OFF
+ -DBUILD_SHARED_LIBS=OFF -DBUILD_DOCS=OFF \
+ -DBUILD_TESTS=ON
But that's the converse of what I proposed. What I proposed is to build
the tests in the shared library build case, so that the tests are small
since they use the shared library. Instead, what got uploaded will build
the tests in the static library build case, and thus each test will
weight about 100MB, thus making the build uselessly big.
Here is a patch that reverses the flags.
Samuel
--- debian/rules.original 2020-01-10 10:58:21.240453383 +0100
+++ debian/rules 2020-01-10 10:58:28.520509620 +0100
@@ -142,12 +142,12 @@
-- $(CMAKE_FLAGS) \
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE="$(LDFLAGS)" \
-DBUILD_SHARED_LIBS=ON -DBUILD_DOCS=ON \
- -DBUILD_TESTS=OFF
+ -DBUILD_TESTS=ON
# statically linked
dh_auto_configure -B $(BUILDDIR)-static \
-- $(CMAKE_FLAGS) \
-DBUILD_SHARED_LIBS=OFF -DBUILD_DOCS=OFF \
- -DBUILD_TESTS=ON
+ -DBUILD_TESTS=OFF
override_dh_auto_build:
# documentation
