Source: cfengine3
Version: 3.12.1-2
Severity: normal
Tags: patch bullseye sid

Dear Maintainer,

Please consider shipping native systemd services masking the currently
shipped init script (fixes lintian tag[1] in subject).

Please note that systemd services are already provided by upstream!
I'm attaching a patch that simply installs them (which has only been
build-tested, as I don't personally use cfengine3).

Since you have a home-grown mechanism to enable/disable services,
rather than using the systemwide way[2] you might want to look
into adding maintscript code for a one-time upgrade conversion
of the home-grown state to system-wide so that the new
services maintains their old state.

Regards,
Andreas Henriksson

[1]: 
https://lintian.debian.org/tags/missing-systemd-service-for-init.d-script.html
[2]: 
https://lintian.debian.org/tags/init.d-script-should-always-start-service.html
diff -Nru cfengine3-3.12.1/debian/cfengine3.install 
cfengine3-3.12.1/debian/cfengine3.install
--- cfengine3-3.12.1/debian/cfengine3.install   2019-01-07 10:08:09.000000000 
+0100
+++ cfengine3-3.12.1/debian/cfengine3.install   2020-02-01 16:51:23.000000000 
+0100
@@ -1,2 +1,3 @@
 debian/tmp/usr/bin/*                    usr/sbin/
 debian/tmp/usr/share/cfengine3
+debian/tmp/lib/systemd/system
diff -Nru cfengine3-3.12.1/debian/changelog cfengine3-3.12.1/debian/changelog
--- cfengine3-3.12.1/debian/changelog   2019-01-07 10:08:09.000000000 +0100
+++ cfengine3-3.12.1/debian/changelog   2020-02-01 16:51:23.000000000 +0100
@@ -1,3 +1,11 @@
+cfengine3 (3.12.1-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add configure flag --with-systemd-service=/lib/systemd/system
+  * debian/cfengine3.install: Add /lib/systemd/system
+
+ -- Andreas Henriksson <andr...@fatal.se>  Sat, 01 Feb 2020 16:51:23 +0100
+
 cfengine3 (3.12.1-2) unstable; urgency=medium
 
   * debian/patches:
diff -Nru cfengine3-3.12.1/debian/rules cfengine3-3.12.1/debian/rules
--- cfengine3-3.12.1/debian/rules       2019-01-07 10:08:09.000000000 +0100
+++ cfengine3-3.12.1/debian/rules       2020-02-01 16:51:19.000000000 +0100
@@ -27,6 +27,7 @@
                        --with-workdir=/var/lib/cfengine3 \
                        --with-logdir=/var/log/cfengine3 \
                        --with-piddir=/var/run/cfengine3 \
+                       --with-systemd-service=/lib/systemd/system \
                        --libdir=/usr/lib/cfengine3 \
                        --docdir=\$${prefix}/share/doc/cfengine3 \
                        --datadir=\$${prefix}/share/cfengine3 \

Reply via email to