Source: pinot
Version: 1.10-1.1
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
pinot fails to cross build from source, because it fails finding dbus
libraries using the build architecture pkg-config. This is due to using
AC_PATH_PROG for discovering pkg-config. Usually, one should be using
the PKG_PROG_PKG_CONFIG macro here. Failing that, use AC_PATH_TOOL. The
configure.in also hard codes the build architecture pkg-config instead
of using the discovered one in two occasions. The attached patch fixes
that. After applying it, pinot fails the "if gio can sniff png" check,
because it cannot be performed during cross building. Would it be ok for
you to pass either --enable-gio or --disable-gio to configure to remove
the need for running the test?
In any case, please consider applying the attached patch to fix the
issue with calling pkg-config and close this bug when doing so.
Helmut
--- pinot-1.10.orig/configure.in
+++ pinot-1.10/configure.in
@@ -65,7 +65,7 @@
AC_LANG_CPLUSPLUS
-AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
+PKG_PROG_PKG_CONFIG
AC_PATH_PROG(DESKTOP_INSTALL, desktop-file-install, no)
dnl DEBUG mode
@@ -112,7 +112,7 @@
AM_CONDITIONAL(HAVE_DBUS, false)
if test "x$enable_dbus" = "xyes"; then
PKG_CHECK_MODULES(DBUS, dbus-glib-1)
- DBUS_NUM_VERSION=`pkg-config --modversion dbus-1 | awk 'BEGIN { FS = "."; } { printf "%d", ($1 * 1000 + $2) * 1000 + $3;}'`
+ DBUS_NUM_VERSION=`$PKG_CONFIG --modversion dbus-1 | awk 'BEGIN { FS = "."; } { printf "%d", ($1 * 1000 + $2) * 1000 + $3;}'`
AC_DEFINE_UNQUOTED(DBUS_NUM_VERSION,$DBUS_NUM_VERSION, [DBus version number])
AM_CONDITIONAL(HAVE_DBUS, true)
fi
@@ -414,7 +414,7 @@
AC_SUBST(MISC_LIBS)
AC_CHECK_HEADERS([sys/vfs.h sys/statfs.h sys/mount.h sys/statvfs.h attr/xattr.h dlfcn.h regex.h fnmatch.h pwd.h])
PKG_CHECK_MODULES(MIMEINFO, shared-mime-info )
-SHARED_MIME_INFO_PREFIX=`pkg-config --variable=prefix shared-mime-info`
+SHARED_MIME_INFO_PREFIX=`$PKG_CONFIG --variable=prefix shared-mime-info`
AC_SUBST(SHARED_MIME_INFO_PREFIX)
AC_DEFINE_UNQUOTED(SHARED_MIME_INFO_PREFIX,"$SHARED_MIME_INFO_PREFIX",
[the shared-mime-info prefix])
