Control: severity -1 serious Control: tags -1 + patch On Thursday, March 05 2020, I wrote:
> On Wednesday, January 29 2020, Boyuan Yang wrote: > >> Dear source-highlight maintainer, >> >> Currently source-highlight would FTBFS due to errors when running "make test" >> after build: >> >> https://buildd.debian.org/status/fetch.php?pkg=source-highlight&arch=arm64&ver=3.1.9-1&stamp=1579812231&raw=0 >> >> There are differences between the expected output value and the real value. >> Please investigate into it. > > I took some time to investigate this on amdahl.d.o, and I am not able to > reproduce this failure. I left "make check" running in a loop for > several minutes, and all of the runs successfully passed without a > problem. > > I'm almost sure this was a failure caused by either a non-deterministic > test, or by some broken dependency that got fixed later. I'm therefore > taking the liberty to downgrade the severity of this bug to normal, as > well as retitling it to remove the FTBFS part. Feel free to revert > these changes if you disagree. I stand corrected. The bug has not been fixed, and it's now impacting the latest build even on amd64: https://buildd.debian.org/status/fetch.php?pkg=source-highlight&arch=amd64&ver=3.1.9-1.1&stamp=1583753021&raw=0 I *think* I understand why the problem is manifesting. The issue here is that 'make check' is parallelized, which may cause a race condition due to buffering, redirections and file-writing commands. It's a mess. I can trigger a testsuite error when I locally run 'make check -j6', but the error doesn't happen on 'make check -j1'. For this reason, I'm proposing the patch below, which disables parallelization on dh_auto_test. I am not 100% sure of this analysis, though. But since I can't spend much more time on this, I think it's worth a try. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ diff -Nru source-highlight-3.1.9/debian/changelog source-highlight-3.1.9/debian/changelog --- source-highlight-3.1.9/debian/changelog 2020-03-02 05:16:32.000000000 -0500 +++ source-highlight-3.1.9/debian/changelog 2020-03-09 17:07:08.000000000 -0400 @@ -1,3 +1,12 @@ +source-highlight (3.1.9-1.2) unstable; urgency=medium + + * Non-maintainer upload. + * Disable parallelization when running 'dh_auto_test'. + This is necessary due to racy conditions in the way the testsuite + is run. (Closes: #950177) + + -- Sergio Durigan Junior <sergi...@debian.org> Mon, 09 Mar 2020 17:07:08 -0400 + source-highlight (3.1.9-1.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru source-highlight-3.1.9/debian/rules source-highlight-3.1.9/debian/rules --- source-highlight-3.1.9/debian/rules 2020-03-02 05:16:32.000000000 -0500 +++ source-highlight-3.1.9/debian/rules 2020-03-09 17:06:51.000000000 -0400 @@ -18,3 +18,6 @@ mv $(DESTDIR)/usr/bin/source-highlight-esc.sh $(DESTDIR)/usr/share/source-highlight/ dh_install rm $(DESTDIR)/usr/lib/$(DEB_TARGET_MULTIARCH)/libsource-highlight.la + +override_dh_auto_test: + dh_auto_test --no-parallel
signature.asc
Description: PGP signature
