Hi Raphaël,
On Tue, Mar 24, 2020 at 7:48 AM Raphaël Hertzog
<raph...@offensive-security.com> wrote:
>
> I don't see the point of "absolute-symbolic-link-target-in-source" since
> "source-contains-unsafe-symlink" is already triggered on such files.
Thanks for pointing out the overlap. Unfortunately, the tags are not equivalent.
You can see it in the test for
absolute-symbolic-link-target-in-source. Below are the full results,
including the check 'cruft'. (The 'tags' file is not a good indicator;
Lintian's test suite runs only the check being tested.) As you can
see, the tag source-contains-unsafe-symlink did not appear.
> Please remove that newly added tag.
The new tag was a reaction to a previously unidentified condition
after this important adjustment:
https://salsa.debian.org/lintian/lintian/-/commit/8e5a95d25669052386f1c7206f4eed4e3c1f35d3
Straight removal is not an option but will think of a way to remove the overlap.
Thank you for bringing this matter to our attention.
Kind regards
Felix Lechner
* * *
> W: absolute-target-in-source source: absolute-symbolic-link-target-in-source
> debian/tests/asym -> /dev/null
> W: absolute-target-in-source source: absolute-symbolic-link-target-in-source
> debian/tests/asym2 -> /dev/null
> W: absolute-target-in-source source:
> debian-tests-control-autodep8-is-obsolete debian/tests/control.autodep8
> W: absolute-target-in-source source:
> debian-tests-control-uses-national-encoding at line 2
> W: absolute-target-in-source source: exclusive-runtime-tests-field tests,
> test-command paragraph starting at line 20
> W: absolute-target-in-source source: illegal-runtime-test-name under_score
> paragraph starting at line 5
> W: absolute-target-in-source source: missing-runtime-test-file
> debian/tests/asym paragraph starting at line 35
> W: absolute-target-in-source source: missing-runtime-test-file
> debian/tests/asym1 paragraph starting at line 35
> W: absolute-target-in-source source: missing-runtime-test-file
> debian/tests/broken paragraph starting at line 35
> W: absolute-target-in-source source: missing-runtime-test-file ... use
> --no-tag-display-limit to see all (or pipe to a file/program)
> W: absolute-target-in-source source: obsolete-runtime-tests-restriction
> needs-recommends paragraph starting at line 28
> W: absolute-target-in-source source:
> testsuite-dependency-has-unparsable-elements "missing a comma" (in paragraph
> starting at line 20)
> I: absolute-target-in-source source:
> debian-tests-control-and-control-autodep8 debian/tests/control
> debian/tests/control.autodep8
> I: absolute-target-in-source source: runtime-test-file-is-not-a-regular-file
> debian/tests/fifo
> I: absolute-target-in-source source: runtime-test-file-is-not-a-regular-file
> debian/tests/lfifo
> P: absolute-target-in-source source: unknown-runtime-tests-feature
> unknownfeature paragraph starting at line 24
> P: absolute-target-in-source source: unknown-runtime-tests-field comment
> paragraph starting at line 1
> P: absolute-target-in-source source: unknown-runtime-tests-restriction
> unknownrestriction paragraph starting at line 24
