On Thu, Mar 26, 2020 at 11:20:30PM +1100, Hugh McMaster wrote: > The attached patch uses pkg-config to detect the compiler and linker > flags for YAZ.
Your patch shells out directly to `pkg-config` even if you put a "require pkg-config" on top. That's not appropriate since, for example, it would fail when cross-compiling. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Description: PGP signature