Bug#955186: pbuilder: please have --login run the default login shell, when not bash

[Daniel Shahaf]

Daniel Shahaf wrote on Sat, Mar 28, 2020 at 01:50:38 +0000:
> Please execute the passwd(5)-specified login shell by default.
> 
> The following works for me, but please review.
> 

Need to set $SHELL too.  Revised patch:

[[[
diff --git a/pbuilder b/pbuilder
index ccd7cc0..3067656 100755
--- a/pbuilder
+++ b/pbuilder
@@ -74,7 +74,8 @@ case "$1" in
         fi
 
         executehooks "F"
-        (${CHROOTEXEC} bash -c 'exec -a -bash bash')
+        loginshell=$(${CHROOTEXEC} getent passwd root | cut -d: -f7)
+        (${CHROOTEXEC} bash -c 'export SHELL="$1"; exec -a "-$1" "$1"' . 
"${loginshell}")
         RET=$?
 
         save_aptcache
]]]

Thanks,

Daniel