Source: node-mqtt
Version: 3.0.0-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: umask
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort we noticed that node-
mqtt could not be built reproducibly.
This is because it does not fix the permissions of a number of .js
files (ie. it excludes them via "dh_fixperms -X") and thus they are
affected the build system's umask:
│ │ │ │ --rwxr-xr-x 0 root (0) root (0) 3076 2019-05-27
08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ --rwxr-xr-x 0 root (0) root (0) 2605 2019-05-27
08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js
│ │ │ │ +-rwxrwxr-x 0 root (0) root (0) 3076 2019-05-27
08:20:41.000000 ./usr/share/nodejs/mqtt/bin/pub.js
│ │ │ │ +-rwxrwxr-x 0 root (0) root (0) 2605 2019-05-27
08:20:41.000000 ./usr/share/nodejs/mqtt/bin/sub.js
I can't quite tell the underlying reason for these excludes as the
files appear to be correctly installed for me (ie. 0644) so a patch
attached that simply drops the dh_fixperms override entirely. If it is
needed for another reason, please ensure that any change or similar is
not affected by the umask.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/rules 2020-04-21 09:28:53.592625051 +0100
--- b/debian/rules 2020-04-21 09:31:01.369378048 +0100
@@ -10,11 +10,6 @@
override_dh_auto_build: mqtt.1
dh_auto_build
-override_dh_fixperms:
- dh_fixperms -Xusr/share/nodejs/mqtt/mqtt.js \
- -Xusr/share/nodejs/mqtt/bin/pub.js \
- -Xusr/share/nodejs/mqtt/bin/sub.js
-
override_dh_auto_clean:
$(CURDIR)/debian/tests/generatecert.sh unpatch
dh_auto_clean
