On 2020-05-27 22:28:44 [+0100], Adam D. Barratt wrote: > Control: tags -1 + moreinfo > > On Sun, 2020-05-24 at 17:47 +0200, Sebastian Andrzej Siewior wrote: > > As part of this update I also introduce the `libclamunrar' package > > which only purpose is to depend on libclamunrar9. On the last soname > > bump not everyone noticed that the soname of libclamunrar changed and > > ended up with no unrar support. Due to its non-free nature we can't > > depend on it so it has been suggested to use this package which will > > remain on the next soname bump and pull-in the new libclamunrarX > > library. > > Does anything pull the metapackage in on user systems, or is the > assumption that they will read the changelog and install it?
Not yet. In packaging git for clamav there has been a Suggests: added for libclamunrar. This is as far as we can go given the non-free nature. I didn't add the Suggests to the clamav package for (old)-stable because we don't have it in unstable just yet and I didn't want to upload it with this as the only change. If you approve / prefer / makes sense I could go ahead and add it to the pu before we have it in unstable. > > This version of libclamunrar was in unstable 20th. I didn't backport > > the packaging related changes while preparing this version (I did > > include the update of the copyright file). > > There seem to be a few, e.g. the removal of the dh_auto_install > override, the dropping of "--disable-clamav --without-pcre" from the > configure invocation, and most of the Build-Depends being removed. The override of dh_auto_install was required to remove the .la files so they don't end up in the final package. With the addition of the package, the folders changed and so the removal is no longer required. The libclamunrar is a split of the clamav package and historically included its (clamav's) configure.ac with the required m4 folder and a stripped down Makefile.am. The only reason why pcre was disabled or libssl-dev listed as a dependency was to keep the configure script happy. None of this was really required by the libclamunrar package. That split script needed (yet again) to be fixed / adopted to the new version of the package which led to a lot yelling and swearing during the process. In the middle I just had it and removed manually what I considered was junk in the configure part and removed everything else that had no real reason to be there. I hope that in future (if they touch the unrar bits again) I can just reuse everything and just move libclamunar* folder and be done with it. Side note: this anger about libclamunrar led to writing a glue layer for libarchive. Once it was done I learned about libarchive's limitations i.e. one out of two files from clamav's testsuite couldn't be extracted… > Regards, > > Adam Sebastian
