On Sun, Jun 21, 2020 at 1:32 PM, Vagrant Cascadian <[email protected]>
wrote:
On 2020-06-21, John Franklin wrote:
* Change the name to qemu-test.hd.qcow2 to make it more obvious to
a developer
what the file is and its format.
I'd prefer not to change the filename, as then it would have to be
changed whenever the file format changes.
If the format changes, then the extension should change, too. That's
not a heavy lift.
* Move the file to the $simple_cdd_tmp folder, in a qemu subfolder,
to better
organize it with the rest fo the temporary build files.
Mixed feelings on this; wondering if it wouldn't make sene to go into
the images folder instead. Or maybe $simple_cdd_tmp is fine.
The images folder is where final artifacts end up. All the rest of the
intermediary files are in the tmp directory. This patch puts it in a
place dedicated to the qemu part of the process. If you're runnig with
UEFI firmware, you may want to include `-drive
if=pflash,format=raw,file=profile_OVMF_VARS.fd` to define where the
UEFI nvram should be stored. In that case, the nvram file should also
be in the tmp/qemu directory. (Future patch coming!)
It does seem to change commented out example size, which doesn't seem
necessary, it only being an example? I think I had put an example in
there which was a non-default value for qemu-img at the time... but in
general I'd like to keep the defaults to whatever qemu-img spits out.
Size is a required parameter if the file doesn't already exist.
```
$ qemu-img create test.img
qemu-img: test.img: Image creation needs a size parameter
```
* If hd_img isn't an absolute path, store it in tmp/qemu.
Mixed feelings on that, as mentioned above.
Happy to merge most of it; could you re-write the git history so that
the contested points are in separate commits? Then I can merge the
uncontested patches while we sort out the remainder.
Done.
jf
--
John Franklin
[email protected]
