On Sat, May 23, 2020 at 02:23:21PM +0800, Paul Wise wrote:
> On Fri, 22 May 2020 20:10:55 +0000 Jelmer Vernooij wrote:
> > Who or what the "author" of a particular change is less clear to me.
> > When somebody edits the control file with vim, we obviously don't
> > ascribe that to vim; if they reformat all files with wrap-and-sort, we
> > don't set the author to wrap-and-sort. At what point do we cross over? 
> 
> Its hard to say really. For wrap-and-sort I use Changes-by in the commit msg.
> 
> > lintian-brush is fairly autonomous - it makes changes from start to
> > end, and I think that's probably what sets it apart from the other
> > tools I've mentioned. But isn't fully in the drivers' seat - the
> > committer decides when to run it and with what arguments.
> 
> Perhaps that is what sets it apart from things like bots that
> automatically commit to git and push that to the canonical repo, there
> is always a human driving it and reviewing the commits it makes while
> the Debian Janitor does do autonomous commits when approved for that.
> 
> So I think I'm now leaning towards just Changes-by for commits.
Maybe that's a good place to start.

How does this look to you as an example commit message, as a result of
me running lintian-brush:

Author: Jelmer Vernooij <[email protected]>
Date:   Sat Jun 27 17:07:12 2020 +0000

    Use secure URI in Homepage field.

    Changes-By: lintian-brush

    Fixes: lintian: homepage-field-uses-insecure-uri
    See-also: 
https://lintian.debian.org/tags/homepage-field-uses-insecure-uri.html

(extra space before the tag-specific paragraph because there may be
multiple affected tags)

Cheers,

Jelmer

Reply via email to