Hi,

Le jeudi 30 juillet à 13h 29mn 40s (+0200), наб a écrit :
> 
> On Thu, Jul 30, 2020 at 11:44:33AM +0200, jhcha54008 wrote:
> > -   log "Debian-Ports architecture detected"
> Why is this line removed from the log now?

Oops, you are right, this line should be kept !

> > +   is_ports_architecture=$(cat /usr/lib/choose-mirror/port_architecture)
> Is there any good reason for this to be a subshell instead of read(1)?

This syntax is in use elsewhere in the same file (line 48).
Yes, it may be tempting to spare one shell sublevel and write

read is_ports_architecture < /usr/lib/choose-mirror/port_architecture

Unfortunately, this fails with a return code of 1 : EOF is reached
before the end of the line (as there is no new line at the end of
the file). As a result, the whole script fails (because of option :
set -e)

> наб

Thank you for your help and your corrections to this patch
proposal !

Regards,
JH Chatenet

Reply via email to