Hello Chris,
I am the current gatekeeper for this package written by a previous
developer with significant help from others. Have you reviewed the
current GIT "develop" branch:
https://sourceforge.net/p/ax25mail/ax25mail-utils/ci/develop/tree/
same can be said for the Linpac package:
https://sourceforge.net/p/linpac/linpac/ci/develop/tree/
The last commit for ax25mail-utils was back in late December 2019 and
April 11th 2020 for Linpac so I wouldn't call these as "very much dead
upstream". It's more a matter than it's being sustained. Also, I'm not
very familiar with the Debian packaging process but I've never seen code
reviews come from the packaging process. Is this a new requirement? Is
there a set of required Debian best practices, etc. that is enforced here?
--David
On 08/04/2020 11:31 AM, Christoph Berg wrote:
Control: tags -1 upstream wontfix
gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -Wall -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -c axgetlist.c
In file included from /usr/include/string.h:495,
from axgetlist.c:19:
In function ‘strncat’,
inlined from ‘load_config’ at axgetlist.c:127:42:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning:
‘__builtin___strncat_chk’ output may be truncated copying 1 byte from a string
of length 255 [-Wstringop-truncation]
The package is horrible 1990ies C code cluttered with global variables
that no not even agree about the definitions.
Since it seems very much dead upstream, I think it's best to remove
it, unless someone thinks it is still needed. (In which case we need a
patch to fix this.)
Christoph
