Source: atari800
Version: 4.1.0-1
Severity: normal

A bug report against fteqcc (#968524) prompted me to look for other
instances of the same anti-pattern on codesearch.debian.net.

d/rules in atari800 invokes 'install -s'. However, 'install -s' is usually
only harmful for a Debian package, not helpful: it discards debugging
symbols that could otherwise have gone into a -dbgsym package, when
cross-compiling it uses the wrong strip(1) implementation (from the build
rather than host architecture), and it results in the nostrip option in
DEB_BUILD_OPTIONS being ignored (see Policy ยง4.9.1). Using install
without the -s option, then using debhelper's dh_strip to do the right
Policy-compliant things, would probably be better.

Similarly, d/rules unconditionally strips certain fields from
debian/tmp/usr/bin/atari800, which is unhelpful for all the same reasons.
Again, dh_strip does this right.

    smcv

Reply via email to