Re: GMiller
> For the Debian directory look in:
> 
> Project 52290
> Initial commit Dream push to Salsa-Garie Miller 08 19 20
> Repository
> dream/dream-2.2.1+r1339/debian/
> 
> I pushed my working directory (with screenshots) both as an 'existing folder' 
> and a '.git repo'. If you have any review comments I would be interested.

Sorry, the git layout is completely wrong. The upstream sources (if
you decide to commit them) need to be in the root directory of the
repo, and the debian directory needs to be /debian.

Also, don't add any tarballs (see `pristine-tar` instead, but that is
optional), and don't commit .dsc or .buildlog or whatever. The
screenshots are likely wrong in the repo as well.

Looking over the debian/ dir:

Why Section: non-free/hamradio ?

copyright: you probably don't want to list all files individually. If
all files have the same (C), just add "Files: *".

You never build-depend on a C-compiler, that's what build-essential is
for.

libfaac-dev and libfdk-aac-dev do not exist in unstable. On which
distribution did you test that?

For the binary: Remove all the lib* (and zlib) dependencies,
dpkg-shlibdeps will sort that out automatically.

Things in debian/docs do not need to be installed by debian/install.

Any COPYING file should be installed by dh_installdocs to
/usr/share/doc/$package/copyright.gz, and not under random other
filenames.

Re debian/tests/: GUI apps are hard to test anyway, so that's entirely
optional.

Christoph

Reply via email to