Hello,
another additional diff:
--- diffoscope-159ubuntu1/tests/comparators/test_directory.py 2020-09-04
12:12:52.000000000 +0200
+++ diffoscope-159ubuntu2/tests/comparators/test_directory.py 2020-09-07
20:46:23.000000000 +0200
@@ -33,6 +33,7 @@
TEST_FILE2_PATH = data("text_ascii2")
+@skip_unless_tools_exist("pgpdump")
def test_no_differences():
difference = compare_directories(
os.path.dirname(__file__), os.path.dirname(__file__)
@@ -40,6 +41,7 @@
assert difference is None
+@skip_unless_tools_exist("pgpdump")
def test_no_differences_with_extra_slash():
difference = compare_directories(
os.path.dirname(__file__) + "/", os.path.dirname(__file__)
diff -Nru diffoscope-159ubuntu1/tests/comparators/test_rlib.py
diffoscope-159ubuntu2/tests/comparators/test_rlib.py
--- diffoscope-159ubuntu1/tests/comparators/test_rlib.py 2020-09-07
20:46:23.000000000 +0200
+++ diffoscope-159ubuntu2/tests/comparators/test_rlib.py 2020-09-07
20:46:23.000000000 +0200
@@ -51,6 +51,7 @@
assert isinstance(rlib1, ArFile)
+@skip_unless_tools_exist("pgpdump")
def test_no_differences(rlib1):
difference = rlib1.compare(rlib1)
assert difference is None
@@ -121,6 +122,6 @@
)
-@skip_unless_tools_exist("nm")
+@skip_unless_tools_exist("nm", "pgpdump")
def test_compare_non_existing(monkeypatch, rlib1):
assert_non_existing(monkeypatch, rlib1)
On Mon, 7 Sep 2020 20:53:13 +0200 Gianfranco Costamagna
<[email protected]> wrote:
> Source: diffoscope
> Version: 159
> Severity: serious
>
> Hello, autopkgtests looks sad, pytest-with-recommends works, while pytest
> doesn't, because of missing pgpdump
>
> I did add some @skip_unless_tools_exist("pgpdump") around the failing tests
> (attached the diff), however I don't know
> if this is the right solution, or something better has to be implemented.
>
> G.
