On 13/09/2020 14:50, Tobias Frost wrote: > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > (snipping stuff that is done or settled … Its getting a long mail) > > (regarding the transitinal package and Replace/Breaks versioning) >> OK, will do (unless not done in a MR)> > MR sent. (https://gitlab.com/leamas/opencpn/-/merge_requests/2)
Applied. > For the readers: > - Replace/Break on << 4.8.8~. The ~ ensures that it matches everything that > had > 4.8.8 in it. (where the change happened) > - The transistional package will no longer be built. > > Note that I did not add d/changelog entries; left to you; no need to mention > me. > >> d/rules: (...) > MR sent. (https://gitlab.com/leamas/opencpn/-/merge_requests/1) Applied, but... this was an insane can of worms. As you noted, basically everything under doc/opencpn was removed. However, this was a plain bug. I have patched the installation files to install the required stuff. > The MR tidies up d/rules (removing the need for override_dh_auto_install) by > replacing > the logic with declratavie syntax: > - installing the manpages not via dh_install but with dh_installman. > - using dh_link to build the symlinks to the GPL licenses needed by the > programm. > - be more accurate in d/*install what to install > - use the possiblity to move files around in d/*install > - specify the files not to be installed. (d/not-installed) Thanks for this crash-course in the possibilities using dh_install and friends! Much appreciated. > Regarding the licenses symlinked: Are they acutally used. grep did find > nothing for me… > In this case, the file d/opencpn.links should be removed The license files are linked for formal reasons besides license.txt which is used in runtime (the About dialog). > Please review the changes to the (not-)installed (especially > d/opencpn-dat.ionstall as > you know whether the programm expect those. (After a simply grep I assumed it > does not.) Done, see above. > Please note that there will be an build error I left intentionally: > It does not install CoC-909_2013-InlandECDIS_20170308s.pdf because this file > is a file > - without source (and so also not built from source) > - unclear license (I don't think that is under a DFSG license… Is it > distributeable?) > atm it looks like it needs to be removed via Files-Excluded. Indeed. File dropped, we have a new tag 5.2.00+dfsg1 + a new build patch. > Also no d/changelog entries; left for you to be done… (I do _not_ need credit > for those!) Well, if you don't want credits in the changelog please accept them here: thanks for some really, really useful input which I think has made me a better packager. A new version is uploaded on mentors. Cheers! --alec PS: Every time I upload a new version I get a mail from mentors with a subject line like "opencpn_5.2.0+dfsg1-1: ACCEPTED into unstable". This is definitely wrong, and should perhaps be filed somewhere (?) DS