On Thu, Sep 17, 2020 at 03:44:38PM +0100, Rainer Weikusat wrote: > Package: dialog > Version: 1.3-20190211-ca-003-1 > Severity: normal > Tags: patch upstream > > The --aspect and --tab-len options are processed in the > process_common_options > subroutine called from main. The code changes the corresponding members of > the > dialog_state structure. After this has happened, the code in main calls then > init_dialog routine which unconditionally sets both the aspect ratio and the > tab len to its default value, thereby overwriting any changes which happened > as part of options processing. > > The patch fixes this by changing the init_dialog code such that it only sets > these members to their default values if they don't have a value already (ie, > if their value is 0). It also removes a redundant "set aspect ratio to default > if still 0" statement from process_common_options.
hmm - the change to util.c seems okay, but removing the check in dialog.c can change things unexpectedly (since process_common_options can be called after init_dialog). -- Thomas E. Dickey <dic...@invisible-island.net> https://invisible-island.net ftp://ftp.invisible-island.net
signature.asc
Description: PGP signature
