On 2020-10-05 15:35:23 +0200, Gianfranco Costamagna wrote:
> In this case, the symbols were private, and incorrectly exposed
> outside, so removing them is "safe" as long as nobody uses them.
I've looked at the repository, and in more details, they were
incorrectly exposed outside via the symbol table, but not via
a header file.[*] Thus I agree that there is no chance that
anyone uses them via the API.
[*] as the issue was fixed only by adding "static":
commit 62614a46609d85f03d9b73a826f8c94a3554e2b1
Author: Povilas Kanapickas <povi...@radix.lt>
Date: 2020-03-28 21:08:39 +0100
sanei_usb: Use internal linkage for private static variables
diff --git a/sanei/sanei_usb.c b/sanei/sanei_usb.c
index db0f452ae..291a48024 100644
--- a/sanei/sanei_usb.c
+++ b/sanei/sanei_usb.c
@@ -195,15 +195,15 @@ static sanei_usb_testing_mode testing_mode =
sanei_usb_testing_mode_disabled;
#if WITH_USB_RECORD_REPLAY
static int testing_development_mode = 0;
-int testing_known_commands_input_failed = 0;
-unsigned testing_last_known_seq = 0;
-SANE_String testing_record_backend = NULL;
-xmlNode* testing_append_commands_node = NULL;
+static int testing_known_commands_input_failed = 0;
+static unsigned testing_last_known_seq = 0;
+static SANE_String testing_record_backend = NULL;
+static xmlNode* testing_append_commands_node = NULL;
// XML file from which we read testing data
-SANE_String testing_xml_path = NULL;
-xmlDoc* testing_xml_doc = NULL;
-xmlNode* testing_xml_next_tx_node = NULL;
+static SANE_String testing_xml_path = NULL;
+static xmlDoc* testing_xml_doc = NULL;
+static xmlNode* testing_xml_next_tx_node = NULL;
#endif // WITH_USB_RECORD_REPLAY
#if defined(HAVE_LIBUSB_LEGACY) || defined(HAVE_LIBUSB)
> So, yes, the ABI changed, but the change was not reflected into
> a real issue for any Debian application, or any custom-built
> application.
Actually, though the symbol table changed, the ABI didn't.
--
Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
