Bug#362209: FTBFS with GCC 4.2: invalid pure specifier

[Roland Stigge]

Hi,

Martin Michlmayr wrote:
> Your package fails to build with GCC 4.2.  Version 4.2 has not been
> released yet but I'm building with a snapshot in order to find errors
> and give people an advance warning.  The bug below is in your package
> and not because I'm using a snapshot of the compiler so please take a
> look at it.  You can reproduce this with the gcc-snapshot package.
> 
> 
>> Automatic build of gcvs_1.0final-11 on em64t by sbuild/amd64 1.112
> ...
>>      g++ -DHAVE_CONFIG_H -I. -I. -I.. -I../gcvs -I../gcvs/src -I/. 
>> -I../cvstree -I../rf  -Wall -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 
>> -I/usr/lib/glib/include -DqUnix -DqGTK -INONE -DqCvsDebug=0  -g -O2 -c -o 
>> AnnotateDlg.o `test -f 'AnnotateDlg.cpp' || echo './'`AnnotateDlg.cpp
>> Persistent.h:50: error: invalid pure specifier (only `= 0' is allowed) 
>> before ';' token
>> Persistent.h:52: error: invalid pure specifier (only `= 0' is allowed) 
>> before ';' token
>> make[3]: *** [AnnotateDlg.o] Error 1
>> make[3]: Leaving directory `/build/tbm/gcvs-1.0final/common'

Does the attached patch fix it?

(If not, will there be an experimental gcc-4.2 package available?)

Thanks,

bye,
  Roland

diff -ruN gcvs-1.0final.orig/common/AppGlue.h gcvs-1.0final/common/AppGlue.h
--- gcvs-1.0final.orig/common/AppGlue.h	2002-01-17 18:04:31.000000000 +0100
+++ gcvs-1.0final/common/AppGlue.h	2006-04-13 10:36:53.000000000 +0200
@@ -30,8 +30,8 @@
 class CCvsConsole
 {
 public:
-	virtual long cvs_out(char *txt, long len) = 0L;
-	virtual long cvs_err(char *txt, long len) = 0L;
+	virtual long cvs_out(char *txt, long len) = 0;
+	virtual long cvs_err(char *txt, long len) = 0;
 };
 
 #define errInternal -99
diff -ruN gcvs-1.0final.orig/common/Persistent.h gcvs-1.0final/common/Persistent.h
--- gcvs-1.0final.orig/common/Persistent.h	2002-02-18 04:45:22.000000000 +0100
+++ gcvs-1.0final/common/Persistent.h	2006-04-13 10:37:26.000000000 +0200
@@ -47,9 +47,9 @@
 	CPersistent(const char *uniqueName, kClassPersistent pclass);
 	virtual ~CPersistent();
 
-	virtual unsigned int SizeOf(void) const = 0L;
-	virtual const void *GetData(void) const = 0L;
-	virtual void SetData(const void *ptr, unsigned int size) = 0L;
+	virtual unsigned int SizeOf(void) const = 0;
+	virtual const void *GetData(void) const = 0;
+	virtual void SetData(const void *ptr, unsigned int size) = 0;
 		// virtual access
 	
 	static void SaveAll(void);