Control: tag -1 + patch - moreinfo unreproducible

Hi Sven,

Sven Hartge wrote:
> Um 19:54 Uhr am 19.10.20 schrieb Sven Hartge:
> > If I add the switch "-B" to the make command in gen_compat_def I can 
> > reliably get the test to work correctly even on the systems with the older 
> > filesystem:
> > 
> >    cmd="make -s -B -C $KDIR M=$PWD modules"
> 
> I locally rebuild the iptables-netflow packages with the attached patch 
> applied and this fixes this problem for me.

Thanks for digging that deep. I must admit that I so far never ran
into this kind of problem despite I consider my systems to have quite
some history, too. Bust most installations are nevertheless not older
than mid-2000s. (One excpetion, but there I'm bound to Debian 8 Jessie
as libc and kernel unfortunately kicked out Pentium I support with
Debian 9 Stretch.)

> (This is like #631245 all over again.)

Oh, one of my packages (now), too. Marked as fixed, but not yet
closed. Hmmm. Do you think we can close this now? Lynx no more uses
the alternatives system besides /usr/bin/www-browser and we've cleaned
up that multiple lynx packages mess we had in the past.

> --- a/gen_compat_def
> +++ b/gen_compat_def
> @@ -26,7 +26,7 @@
>  
>    cat > test.c
>    echo obj-m = test.o > Makefile
> -  cmd="make -s -C $KDIR M=$PWD modules"
> +  cmd="make -s -B -C $KDIR M=$PWD modules"
>    echo "$cmd" > log
>    if $cmd >> log 2>&1; then
>      [ "$2" ] && echo "// $2 is declared ${3:+in <$3>}"

Will apply that patch in the next upload.

"-B" is a rather hefty switch, but inside a test it should still be
ok.

Mind submitting a pull request for this upstream at
https://github.com/aabc/ipt-netflow? You are likely better in
explaining the whole background of this patch and we would not have
Chinese whispers when I'd be relaying potential arguments between you
and upstream.

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Reply via email to