Package: bbdb
Version: 2.35.cvs20040528-1
Severity: normal
Tags: upstream patch
I've set news-auto-create-p to a function which returns 'prompt.
However, I'm never asked for confirmation. I have tracked down the
problem to the if construction in bbdb.el and attached a patch.
The problem seems to be that bbdb-annotate-message-sender is always
called with create-p set to 't, causing the short-circuit or evaluation
to suceed before prompt-to-create is even looked at.
He attached patch fixes this issue.
After prompting works now, I discovered that the help screen isn't
shown. I'm going to fill a separate bug about that.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7
Locale: LANG=C, [EMAIL PROTECTED]
Versions of packages bbdb depends on:
ii emacs21 [emacsen] 21.3+1-8 The GNU Emacs editor
ii make 3.80-9 The GNU version of the "make" util
-- no debconf information
bye
Nikolaus
--- bbdb.el 2004-08-11 22:17:28.000000000 +0200
+++ /home/nikratio/bbdb.el 2005-02-23 12:31:12.000000000 +0100
@@ -3178,14 +3178,14 @@
(if (or (null name) (and (stringp name) (string= "" name)))
(if (string-match "[EMAIL PROTECTED]" net)
(setq name (bbdb-clean-username (match-string 0 net)))))
- (setq record (if (or (null prompt-to-create-p)
- create-p
+ (setq record (if (and create-p
+ (or (null prompt-to-create-p)
(if (functionp prompt-to-create-p)
(bbdb-invoke-hook-for-value
prompt-to-create-p)
(bbdb-y-or-n-p
(format "%s is not in the db. Add? "
- (or name net)))))
+ (or name net))))))
(make-vector bbdb-record-length nil))
created-p (not (null record)))
(if record
