Package: oomd
Version: 0.4.0-1
Severity: normal
Tags: patch

Dear Maintainer,

I am happy, that you are providing an init script for the oomd package.

At the moment the script has two small problems:

1) the oomd process cannot detach into background on its own, thus
   `/etc/init.d/oomd start` hangs forever (e.g. during package
   installation)
2) oomd cannot create a PID file. This causes a delay when running
   `/etc/init.d/oomd stop`.

Issue (1) can be fixed by adding `--background` to the
start-stop-daemon call.
Issue (2) can be fixed by adding `--make-pid`.

Attached you find a patch containing these changes.

Thank you for your time!

Cheers,
Lars


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.9.0-1-amd64 (SMP w/4 CPU threads)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages oomd depends on:
ii  init-system-helpers        1.58
ii  libc6                      2.31-4
ii  libelogind0 [libsystemd0]  243.7-1+debian1
ii  libgcc-s1                  10.2.0-15
ii  libjsoncpp1                1.7.4-3.1
ii  libstdc++6                 10.2.0-15

oomd recommends no packages.

oomd suggests no packages.

-- Configuration Files:
/etc/init.d/oomd changed [not included]

-- no debconf information
--- oomd.orig   2020-11-29 05:44:18.587407153 +0100
+++ /etc/init.d/oomd    2020-11-29 05:44:38.092020091 +0100
@@ -34,9 +34,9 @@
 
   touch "$PIDFILE"
 
-  start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --chuid 
"$USER" --test > /dev/null \
+  start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile --exec 
$DAEMON --chuid "$USER" --background --test > /dev/null \
     || return 1
-  start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --chuid 
"$USER" -- \
+  start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile --exec 
$DAEMON --chuid "$USER" --background -- \
     $DAEMON_OPTS > /dev/null 2>&1 \
     || return 2
   return $?

Reply via email to