* Frank Hart <[EMAIL PROTECTED]> [2006-04-15 01:13]:
> This should be changed into
>   --I-swear-I'll-never-give-these-files-to-anyone,-including-hot-babes-TM

What a lame name.

>     jack_helpers.helpers['cdparanoia']['cmd'] = 
> replace(jack_helpers.helpers['cdparanoia']['cmd'], "--abort-on-skip", "")
> NameError: global name 'replace' is not defined

Here:

--- a/jack_checkopts.py~        2006-04-15 19:20:23.000000000 +0200
+++ b/jack_checkopts.py 2006-04-15 19:21:06.000000000 +0200
@@ -208,8 +208,8 @@
         error("can't do fixed bitrate because " + cf['encoder']['val'] + " 
doesn't support it. Use -v")
 
     if cf['_ripper'] == "cdparanoia" and cf['_sloppy']:
-        jack_helpers.helpers['cdparanoia']['cmd'] = 
replace(jack_helpers.helpers['cdparanoia']['cmd'], "--abort-on-skip", "")
-        jack_helpers.helpers['cdparanoia']['otf-cmd'] = 
replace(jack_helpers.helpers['cdparanoia']['otf-cmd'], "--abort-on-skip", "")
+        jack_helpers.helpers['cdparanoia']['cmd'] = 
jack_helpers.helpers['cdparanoia']['cmd'].replace("--abort-on-skip", "")
+        jack_helpers.helpers['cdparanoia']['otf-cmd'] = 
jack_helpers.helpers['cdparanoia']['otf-cmd'].replace("--abort-on-skip", "")
 
     if cf['_query_on_start'] and cf['_query_when_ready']:
         error("it doesn't make sense to query now _and_ when finished.")

> Also, I hope Martin Michlmayr's patch is going to be included to
> make it easier to specify options for e.g. cdparanoia so that jack's
> standard --abort-on-skip option can be easier overridden.

Do you find the patch useful and think the solution of the patch is a
good way to go about it?  I haven't really received any feedback so
far.  But if people think this is the way to go I can try to clean it
up.
-- 
Martin Michlmayr
http://www.cyrius.com/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to