Hi Julian,

> unoptimized XXH3 is the same - two times faster, optimized XXH3 (AVX2) yields
> results similar to Mark Adler's 3-way CRC32c code (another 2 times faster or 
> so),
> just without having all that vendorization :)

OK, so let us get this straight. Thanks for your valuable input!

> > +++ b/debian/libxxhash-dev.install

> > +xxh_x86dispatch.h /usr/include
> 
> (1) /usr/include/xxh_x86dispatch.h works for me too
> (2) might make sense to only ship that file when building with dispatch.

What about cross-building? Could it happen that we build cross for x86
and while the native binaries are not with dispatch, we want the header
available?

But honestly, I am on very thin ice here with my experience! So feel
free to completely rectify me if I am wrong.

> Maybe Filter for DEB_HOST_ARCH_CPU instead, so it works on non-Linux arch, or

Ah, indeed, that is a good point. Thanks.

> You also need to add various _dispatch symbols to the symbols file for
> those architectures, like this, but with (arch=amd64 i386) in front of them
> I suppose.

Yes, I haven't looked into the symbols by now, but yeah, that is
probably a good idea.

Thanks again, I will probably send another version tomorrow (evening
here in Japan) for comments.

Thanks and all the best

Norbert

--
PREINING Norbert                              https://www.preining.info
Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

Reply via email to