Nicholas,

Thanks for the feedback, please see my replies below.

BTW, James, copying you here to notify there is a new version of the
package at the git repository, and that I am converting this bug into
an ITP.


On Sun, 20 Dec 2020 11:11:43 +0300
Nicholas wrote:
> Hello!
> 
> On Fri, 2020-12-11 at 16:09 -0500, Marco Villegas wrote:
> > I have just added a new repository at
> > https://salsa.debian.org/vim-team/vim-solarized which contains some
> > extra changes to reflect the owner change. I also added a new signed
> > tag with the first version.  
> 
> Thank you, Marco Villegas, for packaging original Solarized
> color-scheme for Vim, my favorite color-scheme.
> 
> Once you prepared a new package, I think it makes sense to convert
> this bug to an ITP report[1] against the wnpp pseudo-package.

Right, I will do that now.


> And I noticed also your current variant of the package activates the
> color-scheme instead of default one and so a description of the
> package contradicts a little bit.

A colorscheme in vim is used only when vimrc is configured to get it
used.

In dh-vim-addon, there is an way to define if an vim addon will be
available by default or not, which is independent of the usage of it
for the case of a colorscheme.

I understand the confusion here, mainly on the description, which I
have just changed. BTW I originally started it as an options addon, and
changed it later, see description at the commit[1] for details

> 
> > Description: Solarized Colorscheme for Vim
> >  Solarized is a sixteen color palette with eight monotones, and
> > eight accent colors; designed for use with terminal and gui
> > applications. .
> >  This plugin contains a vim colorscheme plugin using the Solarized
> > palette. .
> >  It is installed as "optional" Vim package, which can be enabled by
> > adding "packadd! solarized" to vimrc.  
> 
> You use the debian/*.vim-addon file, not debian/*.vim-opt-addon, and
> so packadd! command is not needed. Is it intentional?
> 
>  [1]: https://wiki.debian.org/ITP

Hence yes, it is intentional, and thanks for pointing it out.

1:
https://salsa.debian.org/vim-team/vim-solarized/-/commit/36f394c7029ad3a1835aac27ffbf66e9226822e7

Best,

-Marco

Attachment: pgpQEzd8GoTkJ.pgp
Description: Firma digital OpenPGP

Reply via email to