Package: openvpn-systemd-resolved
Version: 1.3.0-3
Severity: normal
Tags: patch
User: [email protected]
Usertags: resolvectl

Hi,

systemd-resolve has been replaced by the resolvectl tool in systemd v239
(i.e. is available since buster). This is from the systemd release
notes:

    * The systemd-resolve tool has been renamed to resolvectl (it also
      remains available under the old name, for compatibility), and its
      interface is now verb-based, similar in style to the other <xyz>ctl
      tools, such as systemctl or loginctl.

systemd-resolve is nowadays merely a symlink pointing at resolvectl and
we'd like to get rid of this compat symlink at some point.

Your package uses the old name like this:

$ grep -E "systemd-resolve\b" -R
run-tests:function systemd-resolve {
run-tests:  _log "systemd-resolve called with: ${@}"
README.md:`openvpn`, which will use the `update-systemd-resolve.conf` file 
instead:
README.md:$ systemd-resolve eu-central-1.console.aws.amazon.com
README.md:$ systemd-resolve eu-central-1.console.aws.amazon.com
update-systemd-resolved:    systemd-resolve --flush-caches


Attached is a patch which uses resolvectl instead.
Please review and consider applying it in your next upload.
It would be great if you can make this upload before the bullseye
release, so we can safely drop the symlink in bullseye+1.

Regards,
Michael
diff --git a/README.md b/README.md
index ba6f559..d1df277 100644
--- a/README.md
+++ b/README.md
@@ -314,10 +314,10 @@ interfaces.
 ### DNSSEC Issues
 
 ```shell
-$ systemd-resolve eu-central-1.console.aws.amazon.com
+$ resolvectl eu-central-1.console.aws.amazon.com
 eu-central-1.console.aws.amazon.com: resolve call failed: DNSSEC validation 
failed: no-signature
 # or
-$ systemd-resolve eu-central-1.console.aws.amazon.com
+$ resolvectl eu-central-1.console.aws.amazon.com
 eu-central-1.console.aws.amazon.com: resolve call failed: DNSSEC validation 
failed: incompatible-server
 ```
 
diff --git a/run-tests b/run-tests
index d2c5d7d..daefb15 100755
--- a/run-tests
+++ b/run-tests
@@ -91,8 +91,8 @@ function ip {
     " 100\n    link/none"
 }
 
-function systemd-resolve {
-  _log "systemd-resolve called with: ${@}"
+function resolvectl {
+  _log "resolvectl called with: ${@}"
 }
 
 function logger {
diff --git a/update-systemd-resolved b/update-systemd-resolved
index 1452e1a..4c63bc7 100755
--- a/update-systemd-resolved
+++ b/update-systemd-resolved
@@ -421,7 +421,7 @@ main() {
 
     "$script_type" "$link" "$if_index" "$@" || return 1
     # Flush the DNS cache
-    systemd-resolve --flush-caches
+    resolvectl flush-caches
   fi
 }
 

Reply via email to