Package: pcp
Version: 5.2.3-1
Followup-For: Bug #962994

This doesn't appear to be fixed. I can see init scripts & cron job
definitions but not systemd units present in the pcp package:

    $ dpkg -L pcp | grep systemd
    /usr/lib/pcp/pmdas/systemd
    /usr/lib/pcp/pmdas/systemd/Install
    /usr/lib/pcp/pmdas/systemd/README
    /usr/lib/pcp/pmdas/systemd/Remove
    /usr/lib/pcp/pmdas/systemd/domain.h
    /usr/lib/pcp/pmdas/systemd/help
    /usr/lib/pcp/pmdas/systemd/pmdasystemd
    /usr/lib/pcp/pmdas/systemd/pmns
    /usr/lib/pcp/pmdas/systemd/root
    /usr/share/man/man1/pmdasystemd.1.gz
    /var/lib/pcp/pmdas/systemd
    /var/lib/pcp/pmdas/systemd/Install
    /var/lib/pcp/pmdas/systemd/README
    /var/lib/pcp/pmdas/systemd/Remove
    /var/lib/pcp/pmdas/systemd/domain.h
    /var/lib/pcp/pmdas/systemd/help
    /var/lib/pcp/pmdas/systemd/pmdasystemd
    /var/lib/pcp/pmdas/systemd/pmns
    /var/lib/pcp/pmdas/systemd/root

In 
<https://buildd.debian.org/status/fetch.php?pkg=pcp&arch=amd64&ver=5.2.3-1&stamp=1608253472&raw=0>
we still have:

    checking if systemd should be used... no

I wish it was possible to see the config.log from this build... but at
least I can reproduce this with pbuilder.

Adding --with-systemd to the configure command line will promote this to
a build error. I recommend making that change in debian/rules so that
this doesn't fall through the cracks:

    --- debian/rules.old        2021-01-04 11:25:11.569164314 +0000
    +++ debian/rules    2021-01-04 11:08:33.345991196 +0000
    @@ -121,7 +121,7 @@
     #       ... Makepkgs uses the latter mechanism to refine the configure
     #       options
     #
    -configure_paths = --prefix=/usr --libexecdir=/usr/lib --sysconfdir=/etc 
--localstatedir=/var --with-rcdir=/etc/init.d --with-sysconfigdir=/etc/default
    +configure_paths = --prefix=/usr --libexecdir=/usr/lib --sysconfdir=/etc 
--localstatedir=/var --with-rcdir=/etc/init.d --with-sysconfigdir=/etc/default 
--with-systemd

     checkdir = test -f debian/rules
     uninstall = cat debian/*.install | sed -e "s,^,debian/$(pcp)/," | xargs rm 
-f

With that in place, I get:

    checking if systemd should be used... configure: error: cannot enable 
systemd support - no systemunitdir path
    make: *** [debian/rules:150: .census] Error 1
    dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
    I: copying local configuration
    E: Failed autobuilding of package

This is because there is no build-dependency on systemd:

    root@fragarach:/build/pcp-5.2.3# dpkg -l systemd
    dpkg-query: no packages found matching systemd

And it's systemd that ships systemd.pc:

    $ dpkg -S /usr/share/pkgconfig/systemd.pc
    systemd: /usr/share/pkgconfig/systemd.pc

I got the build working:

    checking if systemd should be used... yes
    checking systemd/sd-daemon.h usability... yes
    checking systemd/sd-daemon.h presence... yes
    checking for systemd/sd-daemon.h... yes

... by adding the build-dependency:

    $ diff -u debian/control.old debian/control
    --- debian/control.old      2021-01-04 11:24:51.005091436 +0000
    +++ debian/control  2021-01-04 11:25:19.965194070 +0000
    @@ -4,7 +4,7 @@
     Homepage: https://pcp.io
     Maintainer: PCP Development Team <p...@groups.io>
     Uploaders: Nathan Scott <nath...@debian.org>, Ken McDonell 
<k...@kenj.id.au>
    -Build-Depends: bison, flex, gawk, procps, pkg-config, debhelper (>= 5), 
perl (>= 5.6), libreadline-dev | libreadline5-dev | libreadline-gplv2-dev, 
chrpath, libbsd-dev [kfreebsd-any], libkvm-dev [kfreebsd-any], python3-dev, 
libnspr4-dev, libnss3-dev, libsasl2-dev, libuv1-dev, libssl-dev, 
libavahi-common-dev, qtbase5-dev, qtbase5-dev-tools, libqt5svg5-dev, qtchooser, 
autotools-dev, zlib1g-dev, autoconf, libclass-dbi-perl, libdbd-mysql-perl, 
python3-psycopg2, dh-python, libpfm4-dev, libncurses5-dev, python3-six, 
python3-json-pointer, python3-requests, libextutils-autoinstall-perl, 
libxml-tokeparser-perl, librrds-perl, libjson-perl, libwww-perl, 
libnet-snmp-perl, libnss3-tools, liblzma-dev, libsystemd-dev, bpftrace (>= 
0.9.2) [amd64 arm64 ppc64el], libibumad-dev, libibmad-dev, manpages, systemd
    +Build-Depends: bison, flex, gawk, procps, pkg-config, debhelper (>= 5), 
perl (>= 5.6), libreadline-dev | libreadline5-dev | libreadline-gplv2-dev, 
chrpath, libbsd-dev [kfreebsd-any], libkvm-dev [kfreebsd-any], python3-dev, 
libnspr4-dev, libnss3-dev, libsasl2-dev, libuv1-dev, libssl-dev, 
libavahi-common-dev, qtbase5-dev, qtbase5-dev-tools, libqt5svg5-dev, qtchooser, 
autotools-dev, zlib1g-dev, autoconf, libclass-dbi-perl, libdbd-mysql-perl, 
python3-psycopg2, dh-python, libpfm4-dev, libncurses5-dev, python3-six, 
python3-json-pointer, python3-requests, libextutils-autoinstall-perl, 
libxml-tokeparser-perl, librrds-perl, libjson-perl, libwww-perl, 
libnet-snmp-perl, libnss3-tools, liblzma-dev, libsystemd-dev, bpftrace (>= 
0.9.2) [amd64 arm64 ppc64el], libibumad-dev, libibmad-dev, manpages
     Standards-Version: 3.9.3
     X-Python3-Version: >= 3.3
     
(I guess it actually needs to be added to debian/control.master and then
debian/control has to be rebuilt with debian/rules control, I didn't
bother diving too deeply here.)

There's nothing improper about build-depending on systemd. It just makes the
files available for the build--it won't attempt to switch a system over to
booting with systemd (that is done by a separate package, systemd-sysv).

-- System Information:
Debian Release: 10.7
  APT prefers stable-updates
  APT policy: (535, 'stable-updates'), (535, 'stable'), (520, 'testing'), (510, 
'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 4.19.0-9-686-pae (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Reply via email to