On Tue 2021-01-12 18:33:55 +0100, Eduardo Barretto wrote: > Feel free to correct me at any point, but here is what I've experienced. > > It seems like this issue appeared after Launchpad builders started to > recognize the needs-internet restriction, and it seems that > needs-internet is not enough. Here is what the test was returning > before: > opportunistic SKIP unknown restriction needs-internet > And after, when I was applying some fixes: > opportunistic FAIL non-zero exit status 1 > > That's why we added the skippable and exit 77.
ok, but what does "recognize the needs-internet restriction" mean? the
definition of "needs-internet" [0] is:
The test needs unrestricted internet access, e.g. to download test
data that's not shipped as a package, or to test a protocol
implementation against a test server. Please also see the note about
Network access later in this document.
[0]
https://salsa.debian.org/ci-team/autopkgtest/blob/master/doc/README.package-tests.rst
The "Network access" section also says:
[…] In Ubuntu's infrastructure access to sites other than
*.ubuntu.com and *.launchpad.net happens via a proxy (limited to DNS
and http/https).
The patches you've proposed, if i'm understanding them correctly, cause
the test to be skipped because the test really does use unrestricted
Internet -- not only DNS and HTTP/HTTPS.
This makes me think that either Ubuntu's infrastructure shouldn't
consider itself as offering "unrestricted internet access" (meaning, it
should automatically skip any test with a "needs-internet" restriction),
or it should run any test that has a "needs-internet" restriction
outside of the proxied filter.
If there's a need for a different constraint (like
"needs-only-dns-and-http") to match what ubuntu's infrastructure offers,
that might be a separate question. But either the documentation of what
"needs-internet" means needs to change, or Ubuntu's infrastructure
should not claim to support it, if i'm reading the docs correctly.
thanks for raising this issue! I'm happy to talk about it more if
you've got a different interpretation.
Regards,
--dkg
signature.asc
Description: PGP signature
