Source: vulkan-loader
Version: 1.2.162.0-1
Tags: patch

I was looking into reducing vulkan-loader's build-depends and found that
python3 was reported as unused. That struck me as odd and I looked into
why. It turns out that the sources in loader/generated/ are not rebuilt
during package build. Rather than drop the presently unused python3
dependency, I propose actually rebuiling these files. Please consider
applying the attached patch if you agree.

Helmut
diff --minimal -Nru vulkan-loader-1.2.162.0/debian/changelog 
vulkan-loader-1.2.162.0/debian/changelog
--- vulkan-loader-1.2.162.0/debian/changelog    2021-01-07 08:34:46.000000000 
+0100
+++ vulkan-loader-1.2.162.0/debian/changelog    2021-01-29 18:54:15.000000000 
+0100
@@ -1,3 +1,10 @@
+vulkan-loader (1.2.162.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Actually build from source. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Fri, 29 Jan 2021 18:54:15 +0100
+
 vulkan-loader (1.2.162.0-1) unstable; urgency=medium
 
   * New upstream release.
diff --minimal -Nru vulkan-loader-1.2.162.0/debian/clean 
vulkan-loader-1.2.162.0/debian/clean
--- vulkan-loader-1.2.162.0/debian/clean        1970-01-01 01:00:00.000000000 
+0100
+++ vulkan-loader-1.2.162.0/debian/clean        2021-01-29 18:54:15.000000000 
+0100
@@ -0,0 +1 @@
+loader/generated/*
diff --minimal -Nru vulkan-loader-1.2.162.0/debian/rules 
vulkan-loader-1.2.162.0/debian/rules
--- vulkan-loader-1.2.162.0/debian/rules        2021-01-07 08:12:16.000000000 
+0100
+++ vulkan-loader-1.2.162.0/debian/rules        2021-01-29 18:54:15.000000000 
+0100
@@ -28,6 +28,10 @@
        -DVulkanHeaders_INCLUDE_DIR=../vulkan-headers/include \
        -DVulkanRegistry_DIR=../vulkan-headers/registry
 
+override_dh_auto_build:
+       dh_auto_build -- VulkanLoader_generated_source
+       dh_auto_build
+
 override_dh_auto_test:
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
        (cd build; tests/run_all_tests.sh || \

Reply via email to