Source: runit
Version: 2.1.2-39.1
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: cross-satisfiability

runit uses dh-sysuser, which has a number of problems:
 * dh-sysuser breaks cross building.
 * dh-sysuser does not implement policy recommendations.
 * dh-sysuser is a Debian-specific solution and does not work on other
   distributions.
 * dh-sysuser attempts to remove users on purge, which is not project
   consensus.

Instead, I propose using a well-established solution, sysusers.d.
Standard debhelper includes a dh_installsysusers helper that will be
automatically active in compat level 14. It supports two sysusers.d
implementations (systemd and opensysusers). The declarative file format
is distribution-agnostic.

Therefore, I recommend replacing dh-sysuser with dh_installsysusers and
am applying a patch for your convenience.

Helmut
diff --minimal -Nru runit-2.1.2/debian/changelog runit-2.1.2/debian/changelog
--- runit-2.1.2/debian/changelog        2020-12-25 22:31:31.000000000 +0100
+++ runit-2.1.2/debian/changelog        2021-02-03 22:20:37.000000000 +0100
@@ -1,3 +1,10 @@
+runit (2.1.2-39.2) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Replace dh-sysuser with standard dh_installsysusers. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 03 Feb 2021 22:20:37 +0100
+
 runit (2.1.2-39.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --minimal -Nru runit-2.1.2/debian/control runit-2.1.2/debian/control
--- runit-2.1.2/debian/control  2020-12-25 22:31:12.000000000 +0100
+++ runit-2.1.2/debian/control  2021-02-03 22:20:37.000000000 +0100
@@ -5,10 +5,10 @@
 Standards-Version: 4.5.1
 Homepage: http://smarden.org/runit/
 Build-Depends: bash-completion,
+               debhelper (>= 13.3.3~),
                debhelper-compat (= 13),
                dh-exec,
                dh-runit (>= 2.10.2),
-               dh-sysuser (>= 1.3.3~),
                dh-buildinfo (>= 0.11+nmu1),
                doc-base,
 Vcs-Browser: https://salsa.debian.org/debian/runit
diff --minimal -Nru runit-2.1.2/debian/rules runit-2.1.2/debian/rules
--- runit-2.1.2/debian/rules    2020-12-25 22:31:12.000000000 +0100
+++ runit-2.1.2/debian/rules    2021-02-03 22:20:37.000000000 +0100
@@ -10,7 +10,7 @@
 
 %:
        dh $@ --sourcedirectory=runit-$(DEB_VERSION_UPSTREAM)/src \
-             --with bash_completion,runit,buildinfo,sysuser
+             --with bash_completion,runit,buildinfo
 
 override_dh_auto_configure:
        echo $(CC) $(CFLAGS) > runit-$(DEB_VERSION_UPSTREAM)/src/conf-cc
@@ -22,6 +22,7 @@
        dh_auto_build
 
 override_dh_installsystemd:
+       dh_installsysusers
        dh_installsystemd --name runit --no-stop-on-upgrade
 
 override_dh_installman-arch:
diff --minimal -Nru runit-2.1.2/debian/runit.sysuser 
runit-2.1.2/debian/runit.sysuser
--- runit-2.1.2/debian/runit.sysuser    2020-12-25 22:31:12.000000000 +0100
+++ runit-2.1.2/debian/runit.sysuser    1970-01-01 01:00:00.000000000 +0100
@@ -1,2 +0,0 @@
-runit-log defaults
-_runit-log defaults
diff --minimal -Nru runit-2.1.2/debian/runit.sysusers 
runit-2.1.2/debian/runit.sysusers
--- runit-2.1.2/debian/runit.sysusers   1970-01-01 01:00:00.000000000 +0100
+++ runit-2.1.2/debian/runit.sysusers   2021-02-03 22:20:28.000000000 +0100
@@ -0,0 +1,2 @@
+u      runit-log       -       -       /nonexistent
+u      _runit-log      -       -       /nonexistent

Reply via email to