pe 19. helmik. 2021 klo 15.32 Santiago Garcia Mantinan ([email protected]) kirjoitti: > On Feb 18 2021, Martin-Éric Racine wrote: > > This indeed prevents the superfluous fe80 address from appearing when > > the dongle is plugged in after the bridge is already up. It doesn't > > seem to affect traffic connecting via the dongle either. > > I don't get this last sentence, I'm guessing you mean that the patch works > Ok and it doesn't cause any trouble, is that it?
Yes. It doesn't seem to cause any unexpected surprise. > If we are solving something with this patch, can you tell me which of the > bugs we are addressing with you can be closed when we'll apply this patch > and the other suggestions I made to you? #980752 seems like an obvious choice, however only if BRIDGE_HOTPLUG=yes is enabled. IMHO, this should be enabled by default, instead of being an /etc/default variable. I'm undecided on whether the recent improvements to bridge_hw (by interface name, instead of MAC) actually fix #979963. It probably does, but this will require more testing. Of course, the real fix would be for the kernel to skip non-fixed interfaces when picking a random MAC to use for the bridge. I still think that #966319 isn't really fixed, since "all" doesn't really mean "all" it only means "all fixed interfaces." Fixing #981253 would require documenting the minimum and maximum values of all options, and telling which value means highest priority. It might seem like an obvious one, but it's not. Some software uses a low number to indicate higher priority, other uses a high number. One minor point: bridge-utils uses a different regex approach than ifupdown itself. IMHO, it should use the same syntax as ifupdown. I should probably file a separate bug for this. Thanks again for those recent improvements! Martin-Éric
