Hi Frank,

thanks for your asnwer!

On Mon, Mar 08, 2021 at 01:04:36AM +0100, Frank Heckenbach wrote:
> Unfortunately, I can't easily try to reproduce it, either. (It was a
> server, so we had to quickly reboot it to get it running again and
> replace the defective disk soon after; when it happened, I didn't
> have much time to do further tests, and without gdb or strace
> available for a suid program, my options were very limited, anyway.)
> So I guess we have to leave it at that.

Is it ok for you if I close this bug?

> Most likely unrelated, but one thing I did notice when checking the
> code is that sudo_mkdir_parents might UB if path is an empty string,
> since it first does "char *slash = path; strchr (slash + 1, '/');".
> 
> Now I don't know if it's actually possible that it's called with an
> empty string, so it might not be an actual bug, but since I see it's
> coded very defensively overall, an empty string check here might not
> hurt.

Would it be ok for you to file an issue in upstream's bugzilla? Or would
it be more comforable for you if I took this issue upstream? It is
generally more useful when the bug reporter has a direct communications
link to upstream in such cases.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

Reply via email to