On 2021-03-13, Nicolas Boulenguez wrote:
> The suggested style changes do not make sense in unstable during the
> freeze, but may in experimental.
> The diffs attached to intermediate steps
>   980236 980360 980362 980359 980358 980361 980363
> apply to 2021.04-rc3+dfsg-1.

I just applied each of the above patches from each of those bugs against
salsa/master...


> The attached rebased diffs then apply on the result.
> The changes are tightly connected, but order matters because they
> modify the same parts.

Indeed...


> From cfd86d808db372dff154ca6b163edbf67ec38e6d Mon Sep 17 00:00:00 2001
> From: Nicolas Boulenguez <nico...@debian.org>
> Date: Sat, 9 Jan 2021 15:40:19 +0100
> Subject: [PATCH 3/4] Replace many shell constructs with Make constructs
>
> so that each actually executed command is visible in logs, and errors
> are reported immediately.
>
> Delegate selection of host packages to dh_listpackages, and allow the
> caller to build any combination of .debs and platforms by setting Make
> variables on the command line.  For example,
> DEB_BUILD_PROFILES=pkg.uboot.subarch.foo debian/rules build
> is equivalent to
> debian/rules build built_subarchs=u-boot-foo.
> ---
>  debian/bin/update-substvars    |  12 ---
>  debian/rules                   | 146 +++++++++++++++------------------
>  debian/targets.mk              |  43 ++++++++++
>  debian/u-boot-rockchip.install |   7 +-
>  4 files changed, 112 insertions(+), 96 deletions(-)
>  delete mode 100755 debian/bin/update-substvars
>  mode change 100755 => 100644 debian/u-boot-rockchip.install

I can't get this to apply against -rc3 or -rc4 (just updated in
u-boot/master).


These changes are complex enough, it would be preferable to create a
merge request on salsa.

Thanks for all your work on this!


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature

Reply via email to