Control: tags -1 upstream On Thu, 2021-03-18 at 12:05 -0400, Stuart C. Naifeh wrote:
> I suggest encoding the filename to rfc2231 into a separate temporary > buffer, rather than in place, so that the internal attachment > structure maintains the original, utf-8 encoded file name for use > when saving the .msg file. Patch attached. By changing the API and behaviour of an existing libpst function the patch breaks the ABI of libpst so it isn't suitable for inclusion. I would suggest you handle this with a new pst_convert_rfc2231 function, deprecating the old pst_rfc2231 function and making them both wrappers for a private static function to avoid code duplication, or making the old function a wrapper for the new one if possible. I found at least one GitHub project that uses the pst_rfc2231 function, it is a (presumably modified) copy of readpst though. https://github.com/overview/overview-convert-pst > This is probably really an upstream bug, but the libpst website, such > as it is, does not provide for bug reports, and it looks like the > Debian maintainer has made relatively recent commits to the upstream > codebase, so I’m filing here. I don't have access to the upstream Mercurial repository, I can only commit via the upstream maintainer, so please contact them. Here is their email address in case you haven't been able to find it. Please note that they are fairly busy so may take some time to reply. Carl Byington <[email protected]> Once the bug is forwarded and once the patch has been accepted, please either update the bug metadata or let me know so I can. -- bye, pabs https://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
