Control: tags -1 patch

Below is a patch that updates the default synaptic application icon size from
16x16 to 48x48.  According to Git logs the synaptic application icon has been
48x48 since at least 2004.

    $ file pixmaps/synaptic.png
    pixmaps/synaptic.png: PNG image data, 48 x 48, 8-bit/color RGBA, 
non-interlaced


Testing with a small 640x480 resolution desktop size, the higher 48x48
resolution icon looked OK and matched other current desktop applications
(e.g. xfce-terminal).

The current synaptic get_gdk_pixbuf() calls used to read the application icon,
don't define a size parameter, so the header file defaults downscale the icon
to look pixelated.
        ./rgmainwindow.cc:962:   GdkPixbuf *icon = get_gdk_pixbuf( "synaptic" );
        ./rguserdialog.cc:83:   GdkPixbuf *icon = get_gdk_pixbuf( "synaptic" );


I've also submitted a PR with this simple patch.
https://github.com/mvo5/synaptic/pull/79


$ diff -Naur synaptic-0.90.2_orig
synaptic-0.90.2_patch_icon_size_894463_2021-03-21
diff -Naur synaptic-0.90.2_orig/gtk/rgutils.h
synaptic-0.90.2_patch_icon_size_894463_2021-03-21/gtk/rgutils.h
--- synaptic-0.90.2_orig/gtk/rgutils.h  2020-11-16 03:56:34.000000000 -0500
+++ synaptic-0.90.2_patch_icon_size_894463_2021-03-21/gtk/rgutils.h 2021-03-21
16:27:04.326221170 -0400
@@ -51,8 +51,8 @@
 const char *utf8_to_locale(const char *str);
 const char *utf8(const char *str);
 
-GtkWidget *get_gtk_image(const char *name, int size=16);
-GdkPixbuf *get_gdk_pixbuf(const gchar *name, int size=16);
+GtkWidget *get_gtk_image(const char *name, int size=48);
+GdkPixbuf *get_gdk_pixbuf(const gchar *name, int size=48);
 
 std::string SizeToStr(double Bytes);
 bool RunAsSudoUserCommand(std::vector<const gchar *> cmd);
$ 



donfede

Attachment: signature.asc
Description: PGP signature

Reply via email to