Source: u-boot
Severity: wishlist
Tags: patch
I would like your opinion on some connected issues, before maybe
opening separate bugs. The attached changes are not tested, only a
basis for discussion.
--
> > Could you describe the problem d3d3c952 is solving?
> If u-boot-rockchip is excluded using build profiles, it fails to
> build, due to debian/u-boot-rockchip.install trying to install the
> not created debian/build/rockchip_make_fit_atf.
The attachment suggest a probably better fix, reverting to the
original behaviour: build all packages, even if some eventually
contain no platforms because of profiles. Files unrelated with
platforms should then be handled correctly.
--
e1e273b7ed11a7528311f50f24db9e35be4562da debian/rules: When
pkg.uboot.platform.* is in DEB_BUILD_PROFILES, only
The attached commit implements the same effect by overriding some Make
variables instead of increasing the complexity of recipes. The data
flow is more straightforward:
targets.mk sets the default values for all variables
profiles override some variables
Make recipes are as independant as possible on the variable contents
--
> > Profiles cannot select the 'u-boot' package.
> Haven't tried, but I don't see why that wouldn't work.
DEB_BUILD_PROFILES=pkg.uboot.subarch.rochchip selects u-boot-rockchip.deb
but
DEB_BUILD_PROFILES=pkg.uboot.subarch.u-boot fails to select
u-boot-u-boot.deb
On second thought, it may have worked before my changes because
subarch=u-boot was a special case in some shell scripts.
If you want to restore this possibility, I see two options:
- special-case pkg.uboot.subarch.u-boot so that this works:
DEB_BUILD_PROFILES='pkg.uboot.subarch.u-boot
pkg.uboot.subarch.rockchip'
- change the interface to:
DEB_BUILD_PROFILES='pkg.uboot.subarch.u-boot
pkg.uboot.subarch.u-boot-rockchip'
Do you prefer consistency or shorter command lines?
