Hi Gabriel,
On Sun, 2021-03-28 at 12:12 -0300, Gabriel F. T. Gomes wrote:
> On Mon, 15 Mar 2021 07:07:36 -0600 Kevin Locke <[email protected]> wrote:
>> I've attached an updated version
>> which matches & and | in addition to ; as command separators. We may
>> also want to consider modifying the compgen expression in the same way.
>
> I added this patch (with a changelog entry) to the repository at:
>
> https://salsa.debian.org/debian/bash-completion/-/commits/master
Looks great, thanks!
> Then I tested it against as much packages as possible:
>
> # Download packages that have some completion file (get the list from
> apt-file)
> apt-file search "/usr/share/bash-completion/completions" | cut -d ':' -f 1
> | sort -u | tr '\n' ' ' | xargs apt-get source -y
>
> # Unpack all
> for file in *.deb; do dpkg-deb --extract $file extract/; done
>
> # Run each package.bash-completion file against a simplified version
> # of the perl script [1] (with and without this change)
> for i in `find -name *.bash-completion`; do echo $i; perl
> /var/tmp/build-root/test-me/root/perl-pre.pl < $i; done > _result.pre
> for i in `find -name *.bash-completion`; do echo $i; perl
> /var/tmp/build-root/test-me/root/perl-pos.pl < $i; done > _result.pos
>
> # Compare the results
> diff -u1 _result.{pre,pos}
> ./nitrokey-app-1.4.2/debian/nitrokey-app.bash-completion
> -Yes
> +No
>
>
> So, the change seems to affect nitrokey-app only, which is fine...
>
> Nevertheless, I haven't released this to unstable, because of the
> freeze... I'm worried that this change could undesired side-effects
> (such as making other packages loose their completions) at this point
> of the release cycle, even though the test is telling me it won't.
>
> Let me know your thoughts (about this and/or about the tests I ran).
>
>
> I'll submit it to experimental, then, once the freeze is lifted, to
> unstable.
That sounds like a good plan to me. Even with the extra testing (which
I appreciate!) I don't think fixing a single, likely long-standing,
issue with nitrokey-app is worth the risk of inadvertently breaking
other packages during a freeze.
Thanks again,
Kevin
