Hello Ludens (or anyone else interested in picking this up),
Thanks for the patch you submitted for adding a package with python3
bindings for libmount.
Beware: I'm by no means a python (packaging) expert, so anything I say
below might be completely wrong.
Some things you added in the `Package: python3-libmount` part
of debian/control looks possibly wrong to me:
> Package: python3-libmount
> Architecture: linux-any
Why linux-any? libmount1 is any. (Also I'm not sure when
python stuff can be all or any, but I guess any is correct
for something wrapping a c library).
> Section: libdevel
Shouldn't this be 'Section: python` ?
> Priority: optional
> Depends: libmount-dev (= ${binary:Version}),
> libblkid-dev,
> ${misc:Depends}
Depending on the -dev packages looks wrong to me. You likely want
to depend on the runtime packages like libmount1. Possibly
via some automatic variable like ${shlibs:Depends}, rather than
hard-coding the actual binary library packages.
Also shouldn't there be some python-related magic variable in
here as well?
> Multi-Arch: same
Are you sure?
FWIW Please open a merge-request against the util-linux packaging
git repo on salsa.debian.org/debian/util-linux for easier review!
Might also be useful to ask the debian-python lists to review
the changes, which should give extra confidence that your
packaging work follows debian python packaging best practices.
Regards,
Andreas Henriksson
