Control: tags 986671 confirmed upstream
Control: severity 986671 important
Control: forward 986671 https://github.com/OpenAoE/aoetools/issues/6

Adi Kriegisch wrote...

> we recently tested aoe on a newly created bullseye test system and noticed
> that aoe-sancheck did not detect any interfaces. Up to now, we used bios
> device names and had no problems with this whatsoever but the test system
> uses the default interface names (enp*).

Just in case, adding "net.ifnames=0" to the kernel command line restores the
old behaviour - but I understand there are various reasons, up to and including
layer 9, to not do that.

> Looking into the source revealed that "eth" is hardcoded in aoe-sancheck.c
> to find valid interfaces.

Yeah, that doesn't make much sense nowadays. The code really should probe the
interface's capabilities instead, I've made a suggestion in the related
upstream bug.

> The trivial patch attached fixes the issue while still being able to
> correctly identify old interface names as well.
> We'd be very glad if this patch could still make it into bullseye... ;-)

Understood. I'll see what upstream will do about that, quite frankly,
your patch is rather last resort - and I know we're in a time frame
here.

    Christoph

Attachment: signature.asc
Description: PGP signature

Reply via email to