On Fri, Apr 09, 2021 at 09:44:20PM +0200, Helmut Grohne wrote: > Control: tags -1 - patch > > Hi Nilesh, > > On Fri, Apr 09, 2021 at 09:07:31PM +0530, Nilesh Patra wrote: > > Since fokker.dks binary is not being installed, such a compilation would > > not give any exec format problems. And building it via build compiler > > does not seem a problem > > As far as I can see, dksbuild.cc produces a binary format. You can > easily spot that by searching for fread and fwrite. This format is > composed of structures that happen to contain elements of type unsigned > long int. The size of this type is architecture-dependent. Unless I am > mistaken, the output becomes dependent on the bits of the architecture.
Right. > If you download triplane for various architectures and compare > /usr/share/games/triplane/fokker.dks, you'll spot that e.g. amd64 vs > i386 differs, but amd64 vs arm64 does not. Also s390x (which is big > endian) yields yet a different result. ACK, this is probably because of my poor testing there. Admittedly, I did not test extensively. > > I'm attaching my patch along, and will commit to salsa if it looks good. > > NACK. Thanks for the review! > Also shipping the file in /usr/share is a lie. It's > architecture-dependent and therefore should go to /usr/lib. Better still > would be using an architecture-independent file format. Righty Nilesh
signature.asc
Description: PGP signature