As a little follow-up:

We could also avoid the 'python-is-python3' test-dependency by cherry-picking this upstream change: https://github.com/pexpect/pexpect/pull/629

Cheers, Lukas

Am 13.04.21 um 11:47 schrieb Lukas Märdian:
Package: pexpect
Version: 4.8.0-1
Followup-For: Bug #986727
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch

Hi,

I've looked into this recently and I agree we should try to keep as many
tests as possible.

I was able to make some broken tests work by adding the 'needs-root'
restriction (e.g. test_run_event_as_function/method failed with:
'child_result_list': [b'To run a command as administrator
(u...and>".\r\nSee "man sudo_root" for details.\r\n\r\nGO:']).

Furthermore, I added the python-is-python3 dependency to fix errors like
this: "pexpect.exceptions.ExceptionPexpect: The command was not found or
was not executable: python."

Other tests just seem to be flaky as they fail randomly in consecutive
test runs. I sourced the following tests from DebCI, Ubuntu Autopkgtests
and local test runs on LXD and qemu and skipped them in d/tests/control:
   test_before_across_chunks
   test_interact_escape_None
   test_interact_exit_unicode
   test_spawn_uses_env

Thanks for considering the patch.

Cheers,
   Lukas


-- System Information:
Debian Release: bullseye/sid
   APT prefers groovy-updates
   APT policy: (500, 'groovy-updates'), (500, 'groovy-security'), (500, 
'groovy'), (100, 'groovy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.8.0-48-generic (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Reply via email to