Hi! On Tue, 2021-04-13 at 15:36:08 +0200, Ivo De Decker wrote: > On Mon, Apr 12, 2021 at 06:20:10PM +0200, Guillem Jover wrote: > > This is a pre-approval unblock request for dpkg. > > > > [ Reason ] > > > > This includes an RC bug fix, and an old regression affecting apt > > with auto-deconfiguring during upgrades for Protected/Essential > > packages, > > Can you give an example of how this issue can happen (if there is a bug > report, feel free to point at that one).
Right sorry, should have included a reference here. That'd be #983014, I've amended the commit to include that now. > > a regression in the perl code ignoring exceptions, and a > > couple of recent regressions in start-stop-daemon and dpkg-realpath. > > Then a few fixes to the test suite, affecting mostly CPAN. > > > > [ Impact ] > > > > The ones affecting the code would not be good to let as is. The test > > suite ones even though not affecting Debian directly should be safe, > > otherwise they'd not pass. :) > > > > [ Tests ] > > > > The unit tests and the recently merged functional test suite all pass. > > Not all the above are covered by these, but they have been tested > > manually otherwise. I have tests for the exception trapping, but it > > was too invasive so I've queued it for 1.21.x instead. > > > > [ Risks ] > > > > The changes either affect new features (s-s-d), new features breaking > > other parts of the code (dpkg-realpath), or behavior that would > > currently fail anyway (auto-deconfigure for Protected/Essential), > > and that apt will need to workaround for now via --force options. > > > > There should be no behavior changes during source package building, > > except for restoring some error failures that were currently being > > partially ignored (for dpkg-source, but then trapped by dpkg-buildpackage > > f.ex.). (BTW this was not very clear here, but just in case, dpkg-buildpackage currently fails to notice dpkg-source truly failing (because it exits 0), but then fails due to missing files such as the .dsc f.ex., but if you run dpkg-source directly then you'd not get the correct exit code.) > > All changes are fairly minimal. > > Please go ahead with the upload and remove the moreinfo tag from this bug when > the new version is in unstable. Thanks! I'm targeting an upload for later today, but I was thinking I might try to quickly produce a tiny functional test for the auto-deconfigure bug. I'll update the report once I get that, and I could hold the upload until you approve that, but I'm not sure that's worth the round-trip, given that it's a test? :) > [...] > > > The debdiff includes lots of noise due to the po and generated translated > > man pages, that's why I've included the relevant split patches excluding > > translation updates. > > Thanks for that! That made the review a lot easier. > > > And the git branch is at: > > > > https://git.hadrons.org/cgit/debian/dpkg/dpkg.git/log/?h=next/1.20.8 > > > > unblock dpkg/1.20.8 Thanks, Guillem