Control: reopen -1 On 2021, ഏപ്രിൽ 21 9:32:52 PM IST, Yadd <y...@debian.org> wrote: >Le 21/04/2021 à 17:23, Pirate Praveen a écrit : >> On Wed, 21 Apr 2021 15:48:14 +0200 Yadd <y...@debian.org> wrote: >>> Hi, >>> >>> `pretty=describe` uses the result of `git describe`. You got a >>> "4.17.4.20" because this is the last tag on the branch you tried to >>> clone. The "4.17.5" tag is attached to a different branch (unnamed). >>> >>> So uscan is right here ;-) >> >> I don't think uscan is right here. The correct version is available in >> the package.json. I think it'd be a nice option if uscan can pick the >> version available in package.json instead of us adding it manually for >> every update. I currently have to hard code the version in watch file >> which I don't think is a right solution. >> >> Tag is only one way of finding the version and often not used by node >> projects. package.json is also a way to find the version of the node >> module and consistently used by all node modules. Since we already have >> a type=nodejs we know it has a package.json. > >This is not the spirit of HEAD/pretty mode: the goal is to pick commits >after last tag. Upstream did a strange thing in this repo: set a tag >outside any named branch. I'm not sure we should modify uscan because of >an unlikely upstream behavior. >But if Devscript Team agree with you, I can modify "ctype" feature to >fix tag when last tag is lower than package.json#version, then version >will be 4.17.5+timestamp instead of 4.17.4.20+timestamp
I have reopened for comments from devscripts team. It does not have to be the default, but as an optional setting in the watch file. May be ctype=nodejs,version=package.json Or ctype=nodejs,pretty=package.json In this case it should be 4.17.21+git.timestamp.hash as version in package.json is 4.17.21. uscan supports a lot of weird upstream conventions anyway. Many upstream don't use tags consistently so we need ways to handle those cases. Also checksum option does not support mode=git scheme default values. So I used pretty=4.17.21.%cd to force using digits only. Should I open another bug for using checksum with git ? Current it supports only digits in version so ~git or +git or the hash in version does not work. >Cheers, >Yadd -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
