Control: severity -1 important

I don't believe this should be considered an RC bug in Linux packages,
but we should still mitigate the problem.

There are three different bugs involved:

1. linux-headers-*-common uses the upstream Makefile, which defaults
   to attempting a full kernel build.  That will always fail, and
   potentially removes installed files as reported.
2. DKMS (and module-assistant?) do module builds as root by default.
3. Some OOT modules use the now-unsupported SUBDIRS variable instead of
   M or KBUILD_EXTMOD, triggering bug 1.  Due to bug 2, this can remove
   root-owned files.

Bug 3 does/did not only exist in the 2 known bad packages in Debian,
but also probably in other older packages and unpackaged modules.  So I
think we cannot comprehensively fix it or avoid it by using "Breaks"
relations.  (And I would like to avoid the kernel team having to
maintain a list of all currently broken OOT modules.)

Bugs 1 and 2 should be fixed, but this probably isn't achievable before
the bullseye release.

So I propose a mitigation of bug 1: if the Makefile is invoked with
SUBDIRS set but neither M nor KBUILD_EXTMOD is also set, we abort the
build:

https://salsa.debian.org/kernel-team/linux/-/merge_requests/353

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program
than vice versa.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to