Source: mediawiki Version: 1:1.35.2-1 Severity: minor Tags: patch Dear Maintainer,
The install-* autopkgtest require the start of services and should therefore be tagged with the isolation-container restriction. They also use the systemctl command from the systemd package which is missing in the depends field. I also think that the lint test should be marked with the superficial restriction, as it doesn't test the installed packages functionality, but its code style. -- Tobias Wiese PGP KEY: https://tobiaswiese.com/pgp.asc PGP FPR: E1A7A8879BAD75B42D63F3310F067C2DD70E89A0
From 872fc478fc3268fd9874230d613ad3dc8651168d Mon Sep 17 00:00:00 2001 From: Tobias Wiese <tob...@tobiaswiese.com> Date: Mon, 3 May 2021 04:08:42 +0200 Subject: [PATCH 1/2] d/tests: update test restrictions Tag the install-* tests as isolation-container, because they require starting services (apache2 and most of them the database server). Tag the lint test as superficial, because it doesn't test the packages functionality. Signed-off-by: Tobias Wiese <tob...@tobiaswiese.com> --- debian/tests/control | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/debian/tests/control b/debian/tests/control index 89fc86bc..9e4f79b3 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -1,26 +1,27 @@ Tests: lint Depends: @, php-cli, jsonlint +Restrictions: superficial Tests: install-sqlite Depends: @, php-cli, php-sqlite3, curl, sudo, apache2 -Restrictions: needs-root, allow-stderr +Restrictions: needs-root, allow-stderr, isolation-container # default-mysql Tests: install-mysql Depends: @, php-cli, php-mysql, default-mysql-server, curl, sudo, apache2 -Restrictions: needs-root, allow-stderr +Restrictions: needs-root, allow-stderr, isolation-container # mysql Tests: install-mysql Depends: @, php-cli, php-mysql, mysql-server, curl, sudo, apache2 # Don't fail when mysql-server isn't in Debian testing -Restrictions: needs-root, skip-not-installable, allow-stderr +Restrictions: needs-root, skip-not-installable, allow-stderr, isolation-container # mariadb Tests: install-mysql Depends: @, php-cli, php-mysql, mariadb-server, curl, sudo, apache2 -Restrictions: needs-root, allow-stderr +Restrictions: needs-root, allow-stderr, isolation-container Tests: install-postgresql Depends: @, php-cli, php-pgsql, postgresql, curl, sudo, apache2 -Restrictions: needs-root, allow-stderr +Restrictions: needs-root, allow-stderr, isolation-container -- 2.29.2
From 0dfa20aadb525266f23ee3ccf9bcced12bc4f750 Mon Sep 17 00:00:00 2001 From: Tobias Wiese <tob...@tobiaswiese.com> Date: Mon, 3 May 2021 04:23:05 +0200 Subject: [PATCH 2/2] d/tests: Add systemd as test dependency The install-* tests require systemctl which is provided by the systemd package. Signed-off-by: Tobias Wiese <tob...@tobiaswiese.com> --- debian/tests/control | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/debian/tests/control b/debian/tests/control index 9e4f79b3..7dd837d6 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -3,25 +3,25 @@ Depends: @, php-cli, jsonlint Restrictions: superficial Tests: install-sqlite -Depends: @, php-cli, php-sqlite3, curl, sudo, apache2 +Depends: @, php-cli, php-sqlite3, curl, sudo, apache2, systemd Restrictions: needs-root, allow-stderr, isolation-container # default-mysql Tests: install-mysql -Depends: @, php-cli, php-mysql, default-mysql-server, curl, sudo, apache2 +Depends: @, php-cli, php-mysql, default-mysql-server, curl, sudo, apache2, systemd Restrictions: needs-root, allow-stderr, isolation-container # mysql Tests: install-mysql -Depends: @, php-cli, php-mysql, mysql-server, curl, sudo, apache2 +Depends: @, php-cli, php-mysql, mysql-server, curl, sudo, apache2, systemd # Don't fail when mysql-server isn't in Debian testing Restrictions: needs-root, skip-not-installable, allow-stderr, isolation-container # mariadb Tests: install-mysql -Depends: @, php-cli, php-mysql, mariadb-server, curl, sudo, apache2 +Depends: @, php-cli, php-mysql, mariadb-server, curl, sudo, apache2, systemd Restrictions: needs-root, allow-stderr, isolation-container Tests: install-postgresql -Depends: @, php-cli, php-pgsql, postgresql, curl, sudo, apache2 +Depends: @, php-cli, php-pgsql, postgresql, curl, sudo, apache2, systemd Restrictions: needs-root, allow-stderr, isolation-container -- 2.29.2
signature.asc
Description: PGP signature
