On Mon, 21 Jun 2021 at 22:16:17 +0200, Sébastien Noel wrote:
> GIT-fix-adsp_se.patch seems like it could fix something, but honestly,
> even after 20 years of linux gaming (and countless hours of figth with
> oss3, alsa, pulseaudio, oss4), i didn't remenber having to deal with
> /dev/adsp, so "no", i can't say if it solve a real bug or not :/
> (if /dev/adsp is really "alternative DSP/secoundary soundcard", i
> really doubt it will be of use in UT99 or another game of that era)
Right, that's about what I thought. I think there's a genuine bug being
fixed here, but if it's a bug that nobody will ever experience in practice,
then that's not something to change during hard freeze.
> GIT-fix-compiler-warnings.patch is more or less a no-op
Yes, that's how it seemed to me.
> Those 2 patches seemed like a good fit for the (very) slow moving
> target the osspd package is, but i agree the timing was wrong :/
Yeah, sorry, 2 months into hard freeze was not the time to be making
changes that don't fix a concrete, user-visible bug. They seem like good
changes, just not good changes *now*.
I think the conservative thing to do here is to drop those two patches
(which leaves fixing #986662 as the only remaining change since 1.3.2-11),
and then ask the release team to unblock the resulting package.
Ralf, may I do another NMU dropping those patches to keep this moving
along? And then we can discuss how this package is going to be maintained
post-bullseye without being on a time limit.
Thanks,
smcv
