Hi Sebastian!
> So what you're telling me is that this tolower call should actually be
> call to tolower_l with an appropriate locale as kodi only expects
> tolower("...") == "includes.xml" under the C locale.
Very likely it is the more "proper" solution, but to separate
"culture-dependent" and "ordinal" comparisons, one needs to overhaul half of
Kodi.
And this would make the fix unfit for 19.x branch as the regressions would be
just as severe as they could be with CDateTime PR.
I consider this patch as a quick workaround that works on all languages so far
(to my surprise, as I tested that in loop with ~40 languages using API calls &
scrot). As I mentioned in the upstream issue, if this workaround would not have
worked, I'd have either to use tolower_t, toupper_t locale-wise, use
"uselocale(8)" or even switch to ICU. But this worked and upstream approved
PR#19905. Having said that, I think it is good to go.
--
Vasyl Gello
==================================================
Certified SolidWorks Expert
Mob.:+380 (98) 465 66 77
E-Mail: vasek.ge...@gmail.com
Skype: vasek.gello
==================================================
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
