Dear Maintainer,
I tried to have a look and could reproduce the issue.
It seems this got already fixed upstream in [1].
Also a related upstream issue exists [2].
A package built with this patch applied does
not show the fault.
Kind regards,
Bernhard
[1] https://github.com/gwsw/less/commit/520e5c6ea362
[2] https://github.com/gwsw/less/issues/78
# Bullseye/testing amd64 qemu VM 2021-07-09
echo "set enable-bracketed-paste off" >> /etc/inputrc; bash
apt update
apt dist-upgrade
apt install systemd-coredump mc git gdb valgrind rr less-dbgsym fakeroot
apt build-dep less
mkdir /home/benutzer/source/less/orig -p
cd /home/benutzer/source/less/orig
apt source less
cd
dmesg > file
cat file |less
s
/tmp
D
s
/tmp
double free or corruption (fasttop)
Abgebrochen (Speicherabzug geschrieben)
# coredumpctl list
TIME PID UID GID SIG COREFILE EXE
Fri 2021-07-09 16:24:39 CEST 984 0 0 6 present /usr/bin/less
# journalctl -e
# coredumpctl gdb 984
PID: 984 (less)
UID: 0 (root)
GID: 0 (root)
Signal: 6 (ABRT)
Timestamp: Fri 2021-07-09 16:24:39 CEST (2min 12s ago)
Command Line: less
Executable: /usr/bin/less
Control Group: /user.slice/user-1000.slice/session-1.scope
Unit: session-1.scope
Slice: user-1000.slice
Session: 1
Owner UID: 1000 (benutzer)
Boot ID: a8a996b571bb4da1b0927f2faa539137
Machine ID: 33f18f39d2a9438eb75b0ed52848afcd
Hostname: debian
Storage:
/var/lib/systemd/coredump/core.less.0.a8a996b571bb4da1b0927f2faa539137.984.1625840679000000.zst
Message: Process 984 (less) of user 0 dumped core.
Stack trace of thread 984:
#0 0x00007ff6b9082ce1 raise (libc.so.6 + 0x3bce1)
#1 0x00007ff6b906c537 abort (libc.so.6 + 0x25537)
#2 0x00007ff6b90c5768 n/a (libc.so.6 + 0x7e768)
#3 0x00007ff6b90cca5a n/a (libc.so.6 + 0x85a5a)
#4 0x00007ff6b90cdd55 n/a (libc.so.6 + 0x86d55)
#5 0x0000557a43e773ab n/a (less + 0x143ab)
#6 0x0000557a43e78bda n/a (less + 0x15bda)
#7 0x0000557a43e6d97b n/a (less + 0xa97b)
#8 0x0000557a43e6ef9f n/a (less + 0xbf9f)
#9 0x0000557a43e677fe n/a (less + 0x47fe)
#10 0x00007ff6b906dd0a __libc_start_main (libc.so.6 + 0x26d0a)
#11 0x0000557a43e6788a n/a (less + 0x488a)
GNU gdb (Debian 10.1-1.7) 10.1.90.20210103-git
...
Core was generated by `less'.
Program terminated with signal SIGABRT, Aborted.
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 ../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht
gefunden.
(gdb) set width 0
(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007ff6b906c537 in __GI_abort () at abort.c:79
#2 0x00007ff6b90c5768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7ff6b91d3e2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#3 0x00007ff6b90cca5a in malloc_printerr (str=str@entry=0x7ff6b91d61c8 "double
free or corruption (fasttop)") at malloc.c:5347
#4 0x00007ff6b90cdd55 in _int_free (av=0x7ff6b9205b80 <main_arena>,
p=0x557a45a52b10, have_lock=0) at malloc.c:4266
#5 0x0000557a43e773ab in ?? ()
#6 0x0000557a43e78bda in ?? ()
#7 0x0000557a43e6d97b in ?? ()
#8 0x0000557a43e6ef9f in ?? ()
#9 0x0000557a43e677fe in ?? ()
#10 0x00007ff6b906dd0a in __libc_start_main (main=0x557a43e674e0, argc=1,
argv=0x7ffc862ed9c8, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>, stack_end=0x7ffc862ed9b8) at ../csu/libc-start.c:308
#11 0x0000557a43e6788a in ?? ()
export DEBUGINFOD_URLS="https://debuginfod.debian.net";
Core was generated by `less'.
Program terminated with signal SIGABRT, Aborted.
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
Download failed: Das Argument ist ungültig. Continuing without source file
./signal/../sysdeps/unix/sysv/linux/raise.c.
50 ../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht
gefunden.
(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007ff6b906c537 in __GI_abort () at abort.c:79
#2 0x00007ff6b90c5768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7ff6b91d3e2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#3 0x00007ff6b90cca5a in malloc_printerr (str=str@entry=0x7ff6b91d61c8 "double
free or corruption (fasttop)") at malloc.c:5347
#4 0x00007ff6b90cdd55 in _int_free (av=0x7ff6b9205b80 <main_arena>,
p=0x557a45a52b10, have_lock=0) at malloc.c:4266
#5 0x0000557a43e773ab in opt_o (type=<optimized out>, s=0x557a43e8eee0
<cmdbuf> "/tmp") at optfunc.c:118
#6 0x0000557a43e78bda in toggle_option (o=0x557a43e8db80 <option+1152>,
lower=<optimized out>, s=<optimized out>, s@entry=0x557a43e8eee0 <cmdbuf>
"/tmp", how_toggle=<optimized out>) at option.c:446
#7 0x0000557a43e6d97b in exec_mca () at command.c:262
#8 0x0000557a43e6ef9f in mca_char (c=10) at command.c:635
#9 commands () at command.c:1180
#10 0x0000557a43e677fe in main (argc=<optimized out>, argv=0x7ffc862ed9d0) at
main.c:285
https://wiki.debian.org/HowToGetABacktrace
cat file | MALLOC_CHECK_=2 less
...
s
/tmp
D
s
/tmp
...
free(): invalid pointer
Abgebrochen (Speicherabzug geschrieben)
# coredumpctl list
TIME PID UID GID SIG COREFILE EXE
...
Fri 2021-07-09 16:32:14 CEST 1353 0 0 6 present /usr/bin/less
# coredumpctl gdb 1353
...
Core was generated by `less'.
Program terminated with signal SIGABRT, Aborted.
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
Download failed: Das Argument ist ungültig. Continuing without source file
./signal/../sysdeps/unix/sysv/linux/raise.c.
50 ../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht
gefunden.
(gdb) set width 0
(gdb) set pagination off
(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007f36d8e10537 in __GI_abort () at abort.c:79
#2 0x00007f36d8e69768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7f36d8f77e2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#3 0x00007f36d8e70a5a in malloc_printerr (str=str@entry=0x7f36d8f7605a
"free(): invalid pointer") at malloc.c:5347
#4 0x00007f36d8e72ca6 in free_check (mem=0x5614ccd462a0, caller=<optimized
out>) at hooks.c:255
#5 0x00005614cc3d33ab in opt_o (type=<optimized out>, s=0x5614cc3eaee0
<cmdbuf> "/tmp") at optfunc.c:118
#6 0x00005614cc3d4bda in toggle_option (o=0x5614cc3e9b80 <option+1152>,
lower=<optimized out>, s=<optimized out>, s@entry=0x5614cc3eaee0 <cmdbuf>
"/tmp", how_toggle=<optimized out>) at option.c:446
#7 0x00005614cc3c997b in exec_mca () at command.c:262
#8 0x00005614cc3caf9f in mca_char (c=10) at command.c:635
#9 commands () at command.c:1180
#10 0x00005614cc3c37fe in main (argc=<optimized out>, argv=0x7ffe3753af30) at
main.c:285
(gdb) directory /home/benutzer/source/less/orig/less-551
Source directories searched: /home/benutzer/source/less/orig/less-551:$cdir:$cwd
(gdb) up
#1 0x00007f36d8e10537 in __GI_abort () at abort.c:79
Download failed: Das Argument ist ungültig. Continuing without source file
./stdlib/abort.c.
79 abort.c: Datei oder Verzeichnis nicht gefunden.
(gdb) up
#2 0x00007f36d8e69768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7f36d8f77e2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
Download failed: Das Argument ist ungültig. Continuing without source file
./libio/../sysdeps/posix/libc_fatal.c.
155 ../sysdeps/posix/libc_fatal.c: Datei oder Verzeichnis nicht gefunden.
(gdb) up
#3 0x00007f36d8e70a5a in malloc_printerr (str=str@entry=0x7f36d8f7605a
"free(): invalid pointer") at malloc.c:5347
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
5347 malloc.c: Datei oder Verzeichnis nicht gefunden.
(gdb) up
#4 0x00007f36d8e72ca6 in free_check (mem=0x5614ccd462a0, caller=<optimized
out>) at hooks.c:255
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/hooks.c.
255 hooks.c: Datei oder Verzeichnis nicht gefunden.
(gdb) up
#5 0x00005614cc3d33ab in opt_o (type=<optimized out>, s=0x5614cc3eaee0
<cmdbuf> "/tmp") at optfunc.c:118
118 free(namelogfile);
(gdb) print namelogfile
$1 = 0x5614ccd462a0 ""
cat file | valgrind --leak-check=full less
...
s
/tmp
D
s
/tmp
D
q
==6175== Warning: invalid file descriptor -1 in syscall write()
==6175== Invalid free() / delete / delete[] / realloc()
==6175== at 0x48399AB: free (vg_replace_malloc.c:538)
==6175== by 0x11C3AA: opt_o (optfunc.c:118)
==6175== by 0x11DBD9: toggle_option (option.c:446)
==6175== by 0x11297A: exec_mca (command.c:262)
==6175== by 0x113F9E: mca_char (command.c:635)
==6175== by 0x113F9E: commands (command.c:1180)
==6175== by 0x10C7FD: main (main.c:285)
==6175== Address 0x4a5b5a0 is 0 bytes inside a block of size 5 free'd
==6175== at 0x48399AB: free (vg_replace_malloc.c:538)
==6175== by 0x11C3D8: opt_o (optfunc.c:122)
==6175== by 0x11DBD9: toggle_option (option.c:446)
==6175== by 0x11297A: exec_mca (command.c:262)
==6175== by 0x113F9E: mca_char (command.c:635)
==6175== by 0x113F9E: commands (command.c:1180)
==6175== by 0x10C7FD: main (main.c:285)
==6175== Block was alloc'd at
==6175== at 0x483AB65: calloc (vg_replace_malloc.c:760)
==6175== by 0x10CA7D: ecalloc (main.c:317)
==6175== by 0x1166F2: shell_unquote (filename.c:68)
==6175== by 0x11C3BD: opt_o (optfunc.c:120)
==6175== by 0x11DBD9: toggle_option (option.c:446)
==6175== by 0x11297A: exec_mca (command.c:262)
==6175== by 0x113F9E: mca_char (command.c:635)
==6175== by 0x113F9E: commands (command.c:1180)
==6175== by 0x10C7FD: main (main.c:285)
==6175==
echo 1 > /proc/sys/kernel/perf_event_paranoid
cat file | MALLOC_CHECK_=2 rr record less
rr: Saving execution to trace directory `/root/.local/share/rr/less-0'.
...
s
/tmp
D
s
/tmp
...
free(): invalid pointer
Abgebrochen
export DEBUGINFOD_URLS="https://debuginfod.debian.net";
rr replay less-0
set width 0
set pagination off
directory /home/benutzer/source/less/orig/less-551
cont
free(): invalid pointer
Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
Download failed: Das Argument ist ungültig. Continuing without source file
./signal/../sysdeps/unix/sysv/linux/raise.c.
50 ../sysdeps/unix/sysv/linux/raise.c: Datei oder Verzeichnis nicht
gefunden.
(rr) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007fcf326f4537 in __GI_abort () at abort.c:79
#2 0x00007fcf3274d768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7fcf3285be2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#3 0x00007fcf32754a5a in malloc_printerr (str=str@entry=0x7fcf3285a05a
"free(): invalid pointer") at malloc.c:5347
#4 0x00007fcf32756ca6 in free_check (mem=0x56420d4ad2d0, caller=<optimized
out>) at hooks.c:255
#5 0x000056420c9463ab in opt_o (type=<optimized out>, s=0x56420c95dee0
<cmdbuf> "/tmp") at optfunc.c:118
#6 0x000056420c947bda in toggle_option (o=0x56420c95cb80 <option+1152>,
lower=<optimized out>, s=<optimized out>, s@entry=0x56420c95dee0 <cmdbuf>
"/tmp", how_toggle=<optimized out>) at option.c:446
#7 0x000056420c93c97b in exec_mca () at command.c:262
#8 0x000056420c93df9f in mca_char (c=10) at command.c:635
#9 commands () at command.c:1180
#10 0x000056420c9367fe in main (argc=<optimized out>, argv=0x7ffe08751770) at
main.c:285
(rr) reverse-finish
Run back to call of #0 __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:50
Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 in ../sysdeps/unix/sysv/linux/raise.c
(rr) reverse-finish
Run back to call of #0 __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:50
0x00007fcf326f4532 in __GI_abort () at abort.c:79
Download failed: Das Argument ist ungültig. Continuing without source file
./stdlib/abort.c.
79 abort.c: Datei oder Verzeichnis nicht gefunden.
(rr) reverse-finish
Run back to call of #0 0x00007fcf326f4532 in __GI_abort () at abort.c:79
__libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7fcf3285be2d
"%s\n") at ../sysdeps/posix/libc_fatal.c:155
Download failed: Das Argument ist ungültig. Continuing without source file
./libio/../sysdeps/posix/libc_fatal.c.
155 ../sysdeps/posix/libc_fatal.c: Datei oder Verzeichnis nicht gefunden.
(rr) reverse-finish
Run back to call of #0 __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7fcf3285be2d "%s\n") at ../sysdeps/posix/libc_fatal.c:155
0x00007fcf32754a55 in malloc_printerr (str=str@entry=0x7fcf3285a05a "free():
invalid pointer") at malloc.c:5347
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
5347 malloc.c: Datei oder Verzeichnis nicht gefunden.
(rr) reverse-finish
Run back to call of #0 0x00007fcf32754a55 in malloc_printerr
(str=str@entry=0x7fcf3285a05a "free(): invalid pointer") at malloc.c:5347
0x00007fcf32756ca1 in free_check (mem=0x56420d4ad2d0, caller=<optimized out>)
at hooks.c:255
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/hooks.c.
255 hooks.c: Datei oder Verzeichnis nicht gefunden.
(rr) reverse-finish
Run back to call of #0 0x00007fcf32756ca1 in free_check (mem=0x56420d4ad2d0,
caller=<optimized out>) at hooks.c:255
0x00007fcf327597c1 in __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3095
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
3095 malloc.c: Datei oder Verzeichnis nicht gefunden.
(rr) reverse-finish
Run back to call of #0 0x00007fcf327597c1 in __GI___libc_free
(mem=0x56420d4ad2d0) at malloc.c:3095
opt_o (type=<optimized out>, s=0x56420c95dee0 <cmdbuf> "/tmp") at optfunc.c:118
118 free(namelogfile);
(rr) print namelogfile
$1 = 0x56420d4ad2d0 ""
(rr) b __GI___libc_free if mem==0x56420d4ad2d0
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
Breakpoint 1 at 0x7fcf32759720: file malloc.c, line 3092.
(rr) print &namelogfile
$2 = (char **) 0x56420c95d700 <namelogfile>
(rr) watch *0x56420c95d700
Hardware watchpoint 2: *0x56420c95d700
(rr) reverse-cont
Continuing.
Breakpoint 1, __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
3092 malloc.c: Datei oder Verzeichnis nicht gefunden.
(rr) bt
#0 __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
#1 0x000056420c93c161 in getccu () at command.c:866
#2 0x000056420c93c64a in getcc_repl (orig=0x56420c95d770 <sbuf+16> "\033OM",
gr_ungetc=0x56420c93c1a0 <ungetcc>, gr_getc=0x56420c93c140 <getccu>,
repl=<synthetic pointer>) at command.c:889
#3 0x000056420c93d2c7 in getcc () at command.c:926
#4 commands () at command.c:1802
#5 0x000056420c9367fe in main (argc=<optimized out>, argv=0x7ffe08751770) at
main.c:285
(rr) reverse-finish
Run back to call of #0 __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
getccu () at command.c:866
866 free(ug);
(rr) print ug
$3 = (struct ungot *) 0x56420d4ad2d0
(rr) reverse-cont
Continuing.
Breakpoint 1, __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
Download failed: Das Argument ist ungültig. Continuing without source file
./malloc/malloc.c.
3092 malloc.c: Datei oder Verzeichnis nicht gefunden.
(rr) bt
#0 __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
#1 0x000056420c9463d9 in opt_o (type=<optimized out>, s=<optimized out>) at
optfunc.c:122
#2 0x000056420c947bda in toggle_option (o=0x56420c95cb80 <option+1152>,
lower=<optimized out>, s=<optimized out>, s@entry=0x56420c95dee0 <cmdbuf>
"/tmp", how_toggle=<optimized out>) at option.c:446
#3 0x000056420c93c97b in exec_mca () at command.c:262
#4 0x000056420c93df9f in mca_char (c=10) at command.c:635
#5 commands () at command.c:1180
#6 0x000056420c9367fe in main (argc=<optimized out>, argv=0x7ffe08751770) at
main.c:285
(rr) reverse-finish
Run back to call of #0 __GI___libc_free (mem=0x56420d4ad2d0) at malloc.c:3092
0x000056420c93fa2d in use_logfile (filename=0x56420d4ad2d0 "/tmp") at edit.c:857
857 free(filename);
(rr) print filename
$4 = 0x56420d4ad2d0 "/tmp"
(rr) reverse-cont
Continuing.
Hardware watchpoint 2: *0x56420c95d700
Old value = 223007440
New value = 0
0x000056420c9463c1 in opt_o (type=<optimized out>, s=<optimized out>) at
optfunc.c:120
120 namelogfile = shell_unquote(filename);
(rr) disa 2
(rr) next
121 free(filename);
(rr) bt
#0 opt_o (type=<optimized out>, s=<optimized out>) at optfunc.c:121
#1 0x000056420c947bda in toggle_option (o=0x56420c95cb80 <option+1152>,
lower=<optimized out>, s=<optimized out>, s@entry=0x56420c95dee0 <cmdbuf>
"/tmp", how_toggle=<optimized out>) at option.c:446
#2 0x000056420c93c97b in exec_mca () at command.c:262
#3 0x000056420c93df9f in mca_char (c=10) at command.c:635
#4 commands () at command.c:1180
#5 0x000056420c9367fe in main (argc=<optimized out>, argv=0x7ffe08751770) at
main.c:285
(rr) print namelogfile
$7 = 0x56420d4ad2d0 "/tmp"
https://github.com/gwsw/less/issues/78
mkdir source/less/git
cd source/less/git/
git clone https://github.com/gwsw/less
cd less
make -f Makefile.aut
sh configure
make
cat file | MALLOC_CHECK_=2 /home/benutzer/source/less/git/less/less
--> no failure
git bisect start
git bisect good v551
git bisect bad bf7c8ce04e
binäre Suche: danach noch 158 Commits zum Testen übrig (ungefähr 7 Schritte)
[4e33bffb36c63ea767d183ff5b32c238748a91fa] Merge branch 'master' of
https://github.com/gwsw/less into master
make -f Makefile.aut
sh configure
make clean && make
#no failure
git bisect bad
binäre Suche: danach noch 79 Commits zum Testen übrig (ungefähr 6 Schritte)
[e5c98f486b9496ad32be03cac1d2cc8b962ffb23] Documentation.
make -f Makefile.aut
sh configure
make clean && make
#no failure
git bisect bad
binäre Suche: danach noch 39 Commits zum Testen übrig (ungefähr 5 Schritte)
[e8a6d86824b5138877598b112578eb96c34c9faa] Remove unnecessary and incorrectly
used variable same_pos_bell.
make -f Makefile.aut
sh configure
make clean && make
#no failure
git bisect bad
binäre Suche: danach noch 19 Commits zum Testen übrig (ungefähr 4 Schritte)
[dc815a7b7667b4eb82b3d33c9126ae1cb2f41cc9] v554
make -f Makefile.aut
sh configure
make clean && make
git bisect bad
binäre Suche: danach noch 8 Commits zum Testen übrig (ungefähr 3 Schritte)
[a2f1742546f334eb0cf39ec8bff6bdc158fe8382] Merge branch 'master' of
https://github.com/gwsw/less
#failed
git bisect good
binäre Suche: danach noch 4 Commits zum Testen übrig (ungefähr 2 Schritte)
[b88820d3af7e73bad2bfea8f50ce4ac97ef65957] Remove redundant preprocessing of
the less.hlp file (#34)
#failed
git bisect good
binäre Suche: danach noch 1 Commit zum Testen übrig (ungefähr 1 Schritt)
[350bddc753ebe7b7437089f0a067b8ba308c7080] Merge branch 'master' of
https://github.com/gwsw/less
#no failure
git bisect bad
binäre Suche: danach noch 1 Commit zum Testen übrig (ungefähr 1 Schritt)
[520e5c6ea36289c3cc978bd0e8c86cf0a14bc4b7] Remove erroneous free() in
use_logfile.
#no failure
git bisect bad
520e5c6ea36289c3cc978bd0e8c86cf0a14bc4b7 is the first bad commit
commit 520e5c6ea36289c3cc978bd0e8c86cf0a14bc4b7
Author: Mark Nudelman <ma...@greenwoodsoftware.com>
Date: Sun Jan 19 09:29:37 2020 -0800
Remove erroneous free() in use_logfile.
edit.c | 1 -
1 file changed, 1 deletion(-)
.
git show 520e5c6ea36289c3cc978bd0e8c86cf0a14bc4b7
commit 520e5c6ea36289c3cc978bd0e8c86cf0a14bc4b7 (HEAD, refs/bisect/bad)
Author: Mark Nudelman <ma...@greenwoodsoftware.com>
Date: Sun Jan 19 09:29:37 2020 -0800
Remove erroneous free() in use_logfile.
diff --git a/edit.c b/edit.c
index 0cc5697..3676971 100644
--- a/edit.c
+++ b/edit.c
@@ -847,7 +847,6 @@ loop:
/*
* Don't do anything.
*/
- free(filename);
return;
case 'q':
quit(QUIT_OK);
cd /home/benutzer/source/less
cp -a orig try1
cd try1/less-551
wget "https://github.com/gwsw/less/commit/520e5c6ea362.patch"; -O
debian/patches/remove_erroneous_free_in_use_logfile.patch
echo remove_erroneous_free_in_use_logfile.patch >> debian/patches/series
dpkg-buildpackage
dpkg -i /home/benutzer/source/less/try1/less_551-2_amd64.deb
/home/benutzer/source/less/try1/less-dbgsym_551-2_amd64.deb
